Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Bundling, axis inversion, and axis hiding #42

Merged
merged 16 commits into from May 21, 2014
Merged

Support for Bundling, axis inversion, and axis hiding #42

merged 16 commits into from May 21, 2014

Conversation

julianheinrich
Copy link
Collaborator

This is to add support for

  • rendering curves instead of lines
  • bundling according to the unique values of a given dimension
  • flipping (inversing) axes
  • hiding axes

See example at the bottom of index.html

@timelyportfolio
Copy link
Contributor

very, very nice addition +++1

@syntagmatic
Copy link
Owner

Julian, this looks like a great update. I will review it tonight.

One question, is this paper available at a public URL? I'm getting a login page when I try to download it. http://diglib.eg.org/EG/DL/conf/EG2013/stars/PDF/095-116.pdf

@julianheinrich
Copy link
Collaborator Author

Hi Kai,

you can get a copy here: [PDF] from ucsc.eduucsc.edu
[PDF]http://classes.soe.ucsc.edu/cmps261/Fall13/papers/hcmarsh/StateXofXtheXArtXofXParallelXCoordinates.pdf
I'll put a preprint on parallelcoordinates.de soon...

On Tue, May 20, 2014 at 1:59 AM, Kai notifications@github.com wrote:

Julian, this looks like a great update. I will review it tonight.

One question, is this paper available at a public URL? I'm getting a login
page when I try to download it.
http://diglib.eg.org/EG/DL/conf/EG2013/stars/PDF/095-116.pdf


Reply to this email directly or view it on GitHubhttps://github.com//pull/42#issuecomment-43522687
.

syntagmatic added a commit that referenced this pull request May 21, 2014
Support for Bundling, axis inversion, and axis hiding
@syntagmatic syntagmatic merged commit 9132f80 into syntagmatic:master May 21, 2014
@syntagmatic
Copy link
Owner

Thanks Julian, I bumped the version to 0.3.0 with this update.

@yiducn
Copy link

yiducn commented Jun 4, 2014

Hi all, is there any demos about hiding axes?

@julianheinrich
Copy link
Collaborator Author

Yes,

the bundling example at the very bottom of
http://syntagmatic.github.io/parallel-coordinates/
uses .hideAxis(["cylinders"]) to hide the axis that was used for bundling.

On Wed, Jun 4, 2014 at 5:41 PM, sunsnowad notifications@github.com wrote:

Hi all, is there any demos about hiding axes?


Reply to this email directly or view it on GitHub
#42 (comment)
.

@yiducn
Copy link

yiducn commented Jun 6, 2014

@julianheinrich
Hi, can I hide axes without using for bundling?
I used this way, but it doesn't work. And no errors in the console.

var parData = d3.parcoords()("#pc")
.data(data).color(color);
.hideAxis(["工厂"])
.mode("queue").render()
.createAxes().brushable().reorderable();

@julianheinrich
Copy link
Collaborator Author

@sunsnowad

Hiding axes should work independently of bundling.
Have you tried to call .hideAxis after creating axes or rendering?

var parData = d3.parcoords()("#pc")
.data(data).color(color);
.mode("queue").render()
.createAxes().brushable().reorderable()
.hideAxis(["工厂"]);

@bbroeksema
Copy link
Collaborator

I know it's too late, but anyhow: I'm somewhat unhappy that this PR got merged as is. Even though I like the feature, this change is changing white space at various places unrelated to the actual changes for the feature. This has messed up my local copy considerably and requires me to reimplement much of the things I was working on.

@syntagmatic Could you please make sure that next time changes are as self-contained as possible?

Cheers, Bertjan

@julianheinrich
Copy link
Collaborator Author

@bbroeksema I apologise for introducing/removing white spaces, some of which were probably produced by my IDE's auto formatting feature. I'll be more careful next time.

@bbroeksema
Copy link
Collaborator

@julianheinrich apologies accepted =:) No hard feelings, it's just somewhat frustrating when these kind of things happen. More careful coding practices are appreciated and encouraged! Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants