New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes #46

Merged
merged 2 commits into from Jun 9, 2014

Conversation

Projects
None yet
2 participants
@bbroeksema
Collaborator

bbroeksema commented Jun 6, 2014

Hi syntagmatic. Here's two bugfixes I did for the parcoords when using it in an internal project. Could you please merge them?

Bertjan Broeksema added some commits Jan 14, 2014

Bertjan Broeksema
Fix unexpected brushReset behavior.
Calling brush() on brushReset leads to __.brushed being set to an empty
array. As a result, a call to render() would lead to an empty ||-coords.
This commit implements (AFAICS) the correct behavior for brushReset. It
sets __.brushed to false and calls render() in stead of brush() when the
g.dimensions are updated.
Bertjan Broeksema
Fix some issues with the resize function.
Although it still doesn't keep the brush on resize, it at least now
properly resets the brushes before it gets in a completely messed up state.
It also checks the flags to reinitialize properly shadows, brushable, and
reorderable after a resize based on the actual settings.

@syntagmatic syntagmatic merged commit cf18377 into syntagmatic:master Jun 9, 2014

@syntagmatic

This comment has been minimized.

Show comment
Hide comment
@syntagmatic

syntagmatic Jun 9, 2014

Owner

Thanks Bertjan!

Owner

syntagmatic commented Jun 9, 2014

Thanks Bertjan!

@bbroeksema bbroeksema deleted the bbroeksema:bugfixes branch Aug 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment