New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Keep axes brushable and reorderable on updates #53

Merged
merged 1 commit into from Aug 15, 2014

Conversation

Projects
None yet
2 participants
@bbroeksema
Collaborator

bbroeksema commented Aug 8, 2014

When I configure my parcoords to be reorderable, and I call updateAxes() at
some point, the axes wouldn't be reorderable afterwards.

Same for brushable.

Bertjan Broeksema
FIX: Keep axes brushable and reorderable on updates
When I configure my parcoords to be reorderable, and I call updateAxes() at
some point, the axes wouldn't be reorderable afterwards.

Same for brushable.

syntagmatic added a commit that referenced this pull request Aug 15, 2014

Merge pull request #53 from bbroeksema/master
FIX: Keep axes brushable and reorderable on updates

@syntagmatic syntagmatic merged commit cfa7c43 into syntagmatic:master Aug 15, 2014

@syntagmatic

This comment has been minimized.

Show comment
Hide comment
@syntagmatic

syntagmatic Aug 15, 2014

Owner

The flags seem like an anti-pattern.

Owner

syntagmatic commented Aug 15, 2014

The flags seem like an anti-pattern.

@bbroeksema

This comment has been minimized.

Show comment
Hide comment
@bbroeksema

bbroeksema Aug 17, 2014

Collaborator

Nope, the createAxes and updateAxes seem like antipatterns to me. I haven't read fully the article you have sent me by mail, but these kind of update functions go against the transformation description pattern. Ideally one just sets a flag for axes and brushable and the parcoords.call(selection) does what it should do.

Collaborator

bbroeksema commented Aug 17, 2014

Nope, the createAxes and updateAxes seem like antipatterns to me. I haven't read fully the article you have sent me by mail, but these kind of update functions go against the transformation description pattern. Ideally one just sets a flag for axes and brushable and the parcoords.call(selection) does what it should do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment