New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes axis hiding without bundling #54

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@julianheinrich
Collaborator

julianheinrich commented Aug 9, 2014

Hiding axes didn't work unless a dimensions were detected prior to calling .hideAxis, e.g. by calling
render() or bundleDimension(). This fix simply calls detectDimensions() upon hiding axes.

Another option would be to update axes in render() in order to reduce side effects.

@bbroeksema

This comment has been minimized.

Show comment
Hide comment
@bbroeksema

bbroeksema Aug 18, 2014

Collaborator

Merged using command line.

@julianheinrich Note, I slightly cleaned up you commits. I got rid of the merge and I squashed the two commits you had into one. The first was referring to an issue in your repo and seemed to deal with the same issue as the second commit.

see 08611d5

This means though that you'll have to update your repo. If I broke something, let me know. In that case I owe you a beer ;).

Cheers, Bertjan

Collaborator

bbroeksema commented Aug 18, 2014

Merged using command line.

@julianheinrich Note, I slightly cleaned up you commits. I got rid of the merge and I squashed the two commits you had into one. The first was referring to an issue in your repo and seemed to deal with the same issue as the second commit.

see 08611d5

This means though that you'll have to update your repo. If I broke something, let me know. In that case I owe you a beer ;).

Cheers, Bertjan

@bbroeksema bbroeksema closed this Aug 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment