New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to retrieve current brush extents. #56

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@bbroeksema
Collaborator

bbroeksema commented Aug 14, 2014

I need this for an application I'm working on. However, this can also serve as a
starting point for fixing the brush resets on resize. I'll have a look at that
soon.

NOTE: I'll rebase this commit master before the merge and create a new pull request. I'm working on multiple fixes/features at the same time.

Bertjan Broeksema
Add a function to retrieve current brush extents.
I need this for an application I'm working on. However, this can also serve as a
starting point for fixing the brush resets on resize. I'll have a look at that
soon.
__.dimensions.forEach(function(d) {
var brush = yscale[d].brush;
if (!brush.empty()) {
// https://github.com/mbostock/d3/wiki/SVG-Controls#brush_extent

This comment has been minimized.

@bbroeksema

bbroeksema Aug 14, 2014

Collaborator

@syntagmatic See the comments in the issue I mentioned. This comment can go. I'll update this merge request tomorrow. So, please wait a bit with merging this one. (Unless you want obsolete comments in the code =;)

@bbroeksema

bbroeksema Aug 14, 2014

Collaborator

@syntagmatic See the comments in the issue I mentioned. This comment can go. I'll update this merge request tomorrow. So, please wait a bit with merging this one. (Unless you want obsolete comments in the code =;)

@bbroeksema

This comment has been minimized.

Show comment
Hide comment
@bbroeksema

bbroeksema Aug 18, 2014

Collaborator

Merged via command line.

Collaborator

bbroeksema commented Aug 18, 2014

Merged via command line.

@bbroeksema bbroeksema closed this Aug 18, 2014

@bbroeksema bbroeksema deleted the bbroeksema:brushextents branch Aug 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment