Skip to content

Conversation

@rhysd
Copy link
Contributor

@rhysd rhysd commented Sep 30, 2016

I found that task list items should hide their heading bullets.

  • like this :)

According to github-markdown-css, 'task-list-item' class will hide the bullets on the head of list items.

https://github.com/sindresorhus/github-markdown-css/blob/gh-pages/github-markdown.css#L666

So I added the class when a list is a task list. I confirmed it worked well with github-markdown-css.

rhysd added 2 commits October 1, 2016 01:42
According to github-markdown-css, 'task-list-item' class will hide the
bullets on the head of list items.
@wooorm
Copy link
Member

wooorm commented Oct 1, 2016

Thanks @rhysd!

Could you make className an array though? This works but doesn’t completely adhere to HAST.

@rhysd
Copy link
Contributor Author

rhysd commented Oct 1, 2016

I will do 👍

@rhysd
Copy link
Contributor Author

rhysd commented Oct 1, 2016

@wooorm I fixed className.

@wooorm wooorm closed this in 046451e Oct 2, 2016
@rhysd rhysd deleted the fix-check-list branch October 2, 2016 13:02
@wooorm wooorm added ⛵️ status/released 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧑 semver/major This is a change labels Aug 11, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have

Development

Successfully merging this pull request may close these issues.

2 participants