Skip to content

Make type definitions work for classic runtime #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make type definitions work for classic runtime #10

wants to merge 1 commit into from

Conversation

@remcohaszing
Copy link
Member

@remcohaszing remcohaszing commented May 3, 2021

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Nesting properties in a @typedef type annotation will generate a namespace, which can be used to generate the required JSX namespace.

@remcohaszing
Make type definitions work for classic runtime
1aa3100 
Nesting properties in a `@typedef` type annotation will generate a namespace,
which can be used to generate the required JSX namespace.
@remcohaszing remcohaszing requested a review from wooorm May 3, 2021 20:19
wooorm pushed a commit that referenced this pull request May 4, 2021
@remcohaszing
Fix types of automatic and classic runtimes
401082d 
Closes GH-10.
Closes GH-11.

Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com>
Reviewed-by: Titus Wormer <tituswormer@gmail.com>
@wooorm
Copy link
Member

wooorm commented May 4, 2021

Superseded by GH-11.

@wooorm wooorm added the 💪 phase/solved Post is done label May 4, 2021
@wooorm wooorm closed this May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wooorm wooorm Awaiting requested review from wooorm

Assignees

No one assigned

Labels

💪 phase/solved Post is done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@remcohaszing @wooorm