Skip to content

Conversation

@malav2110
Copy link
Contributor

No description provided.

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @malav2110! 👍

@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 👶 semver/patch This is a backwards-compatible fix labels Nov 2, 2020
Co-authored-by: Titus <tituswormer@gmail.com>
@ChristianMurphy ChristianMurphy changed the title Added Support for Primitive Types for Attributes Added Support for number type in Attributes Nov 2, 2020
@wooorm
Copy link
Member

wooorm commented Nov 3, 2020

@malav2110 The tests are catching some potential issues: https://travis-ci.org/github/syntax-tree/xastscript/jobs/740919730#L293.

Travis has recently made it essentially impossible to use them for open source, which is why the build was so slow and I didn’t catch it before. I switched to use GH Actions. Rebasing should give you access and fast tests again, and locally you can check your types by running npm test.

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @malav2110!

@wooorm wooorm merged commit b41a287 into syntax-tree:main Nov 6, 2020
@wooorm
Copy link
Member

wooorm commented Nov 6, 2020

Thanks @malav2110, @ChristianMurphy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☂️ area/types This affects typings 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix

Development

Successfully merging this pull request may close these issues.

3 participants