Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tab-completion work with paths and filenames not just command names. #20

Open
syntaxseed opened this issue Oct 10, 2019 · 5 comments
Labels
moderate Issue might require a moderate level of skill.

Comments

@syntaxseed
Copy link
Owner

syntaxseed commented Oct 10, 2019

Hitting tab will attempt to complete command names... but doesn't work with paths or filenames.

@syntaxseed syntaxseed added the moderate Issue might require a moderate level of skill. label Oct 10, 2019
@syntaxseed syntaxseed changed the title Make tab-completion work with paths not just command names. Make tab-completion work with paths and filenames not just command names. Oct 10, 2019
@ghost
Copy link

ghost commented Oct 14, 2019

It seems to me the easiest way to do this would be to run ls in the autoCompleteInput function. It would require either:

  • a refactor of the ls execution since it returns a <pre> wrapped element, or
  • stripping the element and converting it to an array in autoCompleteInput itself.

Let me know which you think would work best and I'll start on it.

@syntaxseed
Copy link
Owner Author

@jacob-shu it might be best to create a generic helper that both ls and the autocomplete functions can make use of. Most of the cruft in the ls command is just formatting.

@John-Nenniger
Copy link
Contributor

Hello!

I found this repo while looking for open source projects to contribute to, looks awesome!

@jacob-shu have you made any progress on this problem? I took a look before realizing that you said you'd start on it, though I only got as far as the refactor problem you mentioned earlier. I'm happy to keep working on it, or I can look into another issue, like the localStorage problem. Sorry about that!

@ghost
Copy link

ghost commented Nov 1, 2019

Hi @John-Nenniger, I haven't done anything appreciable on this issue yet. Feel free to keep going on it!

@syntaxseed
Copy link
Owner Author

syntaxseed commented Nov 1, 2019

Thanks for your help.

@John-Nenniger Note that PR #23 will be merged in next. And might conflict with this work. So have a look there, and/or give me a few days to review it and I'll merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moderate Issue might require a moderate level of skill.
Projects
None yet
Development

No branches or pull requests

2 participants