Skip to content

Commit

Permalink
Removed ThreadScheduler as normal requirement
Browse files Browse the repository at this point in the history
Some environments could have threading disabled, and therefore the threading import can resolve in an error.
This commit fixes that :)
  • Loading branch information
syrusakbary committed Apr 30, 2017
1 parent b2963d2 commit 5fa814d
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 12 deletions.
9 changes: 6 additions & 3 deletions promise/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@
get_default_scheduler,
set_default_scheduler
)
from .scheduler import SyncScheduler, ThreadScheduler
from .scheduler import SyncScheduler
try:
from .thread_sheduler import ThreadScheduler
except ImportError:
pass

__all__ = [
'Promise',
Expand All @@ -34,6 +38,5 @@
'async_instance',
'get_default_scheduler',
'set_default_scheduler',
'SyncScheduler',
'ThreadScheduler'
'SyncScheduler'
]
9 changes: 0 additions & 9 deletions promise/scheduler.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,6 @@
from threading import Thread


class SyncScheduler(object):
def call(self, fn):
try:
fn()
except:
pass


class ThreadScheduler(object):
def call(self, fn):
thread = Thread(target=fn)
thread.start()
7 changes: 7 additions & 0 deletions promise/thread_scheduler.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
from threading import Thread


class ThreadScheduler(object):
def call(self, fn):
thread = Thread(target=fn)
thread.start()

0 comments on commit 5fa814d

Please sign in to comment.