Protocol? #125

Open
marcoscaceres opened this Issue Jun 17, 2013 · 5 comments

Comments

Projects
None yet
2 participants
@marcoscaceres
Contributor

marcoscaceres commented Jun 17, 2013

The spec says:

Since call states can differ depending on the protocol, the telephony call objects contain information which identifies the service and the protocol used for making the call.

I don't see a way of getting the protocol from TelephonyCall or ConferenceCall or CallHandler? What am I missing?

@zolkis

This comment has been minimized.

Show comment
Hide comment
@zolkis

zolkis Jun 17, 2013

Contributor

That should be in TelephonyService, but we only have the serviceId now. There are 3 options: 1) introduce TelephonyService, 2) include the information in every call, or 3) embed it into the serviceId (which becomes a JSON string).

Contributor

zolkis commented Jun 17, 2013

That should be in TelephonyService, but we only have the serviceId now. There are 3 options: 1) introduce TelephonyService, 2) include the information in every call, or 3) embed it into the serviceId (which becomes a JSON string).

@marcoscaceres

This comment has been minimized.

Show comment
Hide comment
@marcoscaceres

marcoscaceres Jun 17, 2013

Contributor
  1. remove mention of protocol from the sentence above?

I guess we need to think about some of the implications of exposing the protocol. What are the use cases for knowing the protocol? what are some of the potential security risks of an attacker knowing the protocol?

Contributor

marcoscaceres commented Jun 17, 2013

  1. remove mention of protocol from the sentence above?

I guess we need to think about some of the implications of exposing the protocol. What are the use cases for knowing the protocol? what are some of the potential security risks of an attacker knowing the protocol?

@zolkis

This comment has been minimized.

Show comment
Hide comment
@zolkis

zolkis Jun 17, 2013

Contributor

Giri and Dan (from AT&T) also expressed the need for the dialers to know the protocol, since it defines a context for the states. I can't see security implications on client side. The information could be extracted anyway, but this would make it easy for developers. This information may not be available.

See also #53.

Contributor

zolkis commented Jun 17, 2013

Giri and Dan (from AT&T) also expressed the need for the dialers to know the protocol, since it defines a context for the states. I can't see security implications on client side. The information could be extracted anyway, but this would make it easy for developers. This information may not be available.

See also #53.

@marcoscaceres

This comment has been minimized.

Show comment
Hide comment
@marcoscaceres

marcoscaceres Jun 18, 2013

Contributor

Ok, maybe we should start seriously discussing adding a TelephonyService (as per #53). Or should we initially just expose protocol as an attribute of TelephonyCall?

Contributor

marcoscaceres commented Jun 18, 2013

Ok, maybe we should start seriously discussing adding a TelephonyService (as per #53). Or should we initially just expose protocol as an attribute of TelephonyCall?

marcoscaceres added a commit to marcoscaceres/telephony that referenced this issue Jun 18, 2013

@zolkis

This comment has been minimized.

Show comment
Hide comment
@zolkis

zolkis Jun 19, 2013

Contributor

Once you will have finished the nolegacy transition, we can start the discussion. I will play with various options until then.

Contributor

zolkis commented Jun 19, 2013

Once you will have finished the nolegacy transition, we can start the discussion. I will play with various options until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment