From fa459bdc87bbb050ca1c8d469023a96ed798540e Mon Sep 17 00:00:00 2001 From: MarcoFalke Date: Wed, 15 Jul 2020 19:45:01 +0200 Subject: [PATCH] rpc: Treat all args after a hidden arg as hidden as well This commit has no effect right now, but hardens the code for the future --- src/rpc/util.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/rpc/util.cpp b/src/rpc/util.cpp index 9f4c7bee9cad1..e3db1dd513f2d 100644 --- a/src/rpc/util.cpp +++ b/src/rpc/util.cpp @@ -504,7 +504,7 @@ std::string RPCHelpMan::ToString() const ret += m_name; bool was_optional{false}; for (const auto& arg : m_args) { - if (arg.m_hidden) continue; + if (arg.m_hidden) break; // Any arg that follows is also hidden const bool optional = arg.IsOptional(); ret += " "; if (optional) { @@ -526,7 +526,7 @@ std::string RPCHelpMan::ToString() const Sections sections; for (size_t i{0}; i < m_args.size(); ++i) { const auto& arg = m_args.at(i); - if (arg.m_hidden) continue; + if (arg.m_hidden) break; // Any arg that follows is also hidden if (i == 0) ret += "\nArguments:\n";