-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jagged edges in the output the masks #25
Comments
Hi, have this line triggered during the inference process? You can try to increase the dilation kernel range to reduce the artifacts. This is the result of the woman running on my local machine. |
Hi @lkeab without the background removed, these edges are not noticeable. I don't see the jagged edges even with my inference, atleast they are not noticeable this way I think. I simply do this to remove the background, so I don't think it is an issue with the background removal process.
I wasn't setting VIS_PERIOD if it is not the default. I have set it now and I can confirm that the code is going to I see below logs during inference, not sure if they are of any significance
|
I did't observe this warning when running my code. |
Could there be an issue with the pytorch/cuda versions? |
Not sure. I am using the NVIDIA TITAN RTX, Pytorch 1.7.1 and Cuda 11.0. |
If you don't mind, is it possible to provide mask object for one of these images(and details on which model and setttings are used) or provide an option in huggingspaces to download it? I would like to compare it with what I am seeing and confirm if it's an env issue or something else. |
Hi, I am currently out for a traveling. I think one validation method is to that you report your AP results for our pretrained model (for example r50-fpn-1x) running on your machine. If it is exactly the same, then I think it can exclude the environment factors. |
I encountered the same warnings! My env setting: ubuntu 20.04, python 3.7.13, pytorch 1.11.0, cuda 11.3. |
@anl13 Do you also see the jagged edges? |
@vanga Yes, I observed exactly the same results. In fact, I have removed these warnings by replacing |
@lkeab Can we keep this open until thee is a closure? considering it is not just me? w.r.t checking AP results, could you please share some pointers on how I can do that? |
Hi, for checking AP results, you can report the inference results on coco val set using our provided pretrained model, such as R50-FPN-1x or 3X. I will also look into this to see whether can help fix it. It's not that noticeable when drawing masks directly on images. |
Hi,
Config: mask_rcnn_R_101_FPN_3x_deform.yaml
checkpoint: output_3x_transfiner_r101_deform.pth
All other settings are defaults from the yaml config.
I am doing prediction like this (I used the demo.py script as wel and the results are same). I don't see any errors/warning in the logs
I see that the edges of the masks are not smooth even for the sample images in the repo. Is this expected? I am askng this because when I look at the gifs in the readme, they seem to have smooth edges. so, I was expecting smooth edges.
The text was updated successfully, but these errors were encountered: