feat(cluster-scanner): added configuration for docker registry mirrors #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michele-mangili
force-pushed
the
mm/cluster-scanner/docker-mirrors
branch
from
471476c to
9e4c506
Compare
mavimo
reviewed
Sep 26, 2023
mavimo
reviewed
Sep 26, 2023
5 tasks
michele-mangili
force-pushed
the
mm/cluster-scanner/docker-mirrors
branch
from
9e4c506 to
876435c
Compare
mech-pig
approved these changes
Oct 4, 2023
aroberts87
approved these changes
Oct 4, 2023
Collaborator
aroberts87
left a comment
aroberts87
left a comment
There was a problem hiding this comment.
lgtm, @michele-mangili! just one minor nit that may just be a result of my lack of knowledge in this area. thanks for addressing the earlier concerns by @mavimo as well. 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As per the title
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
Check Contribution guidelines in README.md for more insight.