Skip to content

Conversation

@patrickeasters
Copy link
Contributor

@patrickeasters patrickeasters commented Nov 7, 2023

What this PR does / why we need it:

To match the docs update, this updates the Helm chart to list GCR as an officially supported registry type.

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@patrickeasters patrickeasters requested review from a team as code owners November 7, 2023 13:23
@mavimo
Copy link
Contributor

mavimo commented Nov 7, 2023

@patrickeasters 👋

You need to run the make docs command to update the README file after the version bump

@patrickeasters
Copy link
Contributor Author

@patrickeasters 👋

You need to run the make docs command to update the README file after the version bump

Thanks! Fixed. I had a wrong version of chart-doc-gen installed that was making a mess of things when I did that earlier.

@airadier airadier merged commit 569fc3e into master Nov 17, 2023
@airadier airadier deleted the gcr branch November 17, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants