feat(modules): Support for Govcloud account/org for fedramp #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change summary: ----------------- 1. Added support to install govcloud single account and org in foundational onboarding module. 2. Added same support in config-posture module. 3. Added same support in event-bridge module. 4. Updated and cleaned up the READMEs of the modules. 5. Added tests for foundational and event-bridge single and org installs.
|
Looks good for the most part ! Great job 👍 Just left a couple of comments & a nit |
jose-pablo-camacho
approved these changes
Nov 12, 2024
Since the gov support requires atleast 1.39 provider version in TF modules, updating the test example snippets.
jose-pablo-camacho
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary: