Skip to content

Conversation

@jose-pablo-camacho
Copy link
Contributor

xref: https://sysdig.atlassian.net/browse/SSPROD-48794

This PR adds S3 support for GovCloud accounts and org.

@jose-pablo-camacho jose-pablo-camacho requested review from a team as code owners October 30, 2024 19:07
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also update the module's versions.tf with the latest provider version. Else the data source calls would fail if this is run on < 1.39 provider.

Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jose-pablo-camacho jose-pablo-camacho merged commit 81addc2 into main Nov 12, 2024
@jose-pablo-camacho jose-pablo-camacho deleted the enhance/s3/add-gov-support branch November 12, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants