-
Notifications
You must be signed in to change notification settings - Fork 54
SSPROD-29308: Implement CloudAccount client v2 for Secure #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSPROD-29308: Implement CloudAccount client v2 for Secure #404
Conversation
Change summary: ----------------- Adding a new CloudAccount client v2 for making Secure BE (cloudauth) APIs to support API-only onboarding support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can use a cloudauth prefix instead of a v2 suffix across the board? E.g. name the file sysdig/internal/client/v2/cloudauth.go and the constants cloudauthAccountPath/cloudauthAccountsPath?
Seems a bit odd to add v2s across the board, especially when refering to an endpoint with v1 in it
Yes, that works too and that's a fair point. I named it with v2 as per the framework suggestion, similar to how they did for alerts_v2.go. But cloudauth also works. (as long as we don't change the name of the service).
Done! |
|
All the latest changes are pulled and merged as part of #407 . Closing this PR then. |
Change summary:
Adding a new Cloudauth Account client for making Secure BE (cloudauth) APIs to support API-only onboarding support.