Skip to content

Conversation

@ravinadhruve10
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 commented Sep 5, 2023

Change summary:

Adding a new Cloudauth Account client for making Secure BE (cloudauth) APIs to support API-only onboarding support.

Change summary:
-----------------
Adding a new CloudAccount client v2 for making Secure BE
(cloudauth) APIs to support API-only onboarding support.
Copy link
Contributor

@nkraemer-sysdig nkraemer-sysdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use a cloudauth prefix instead of a v2 suffix across the board? E.g. name the file sysdig/internal/client/v2/cloudauth.go and the constants cloudauthAccountPath/cloudauthAccountsPath?

Seems a bit odd to add v2s across the board, especially when refering to an endpoint with v1 in it

Yes, that works too and that's a fair point. I named it with v2 as per the framework suggestion, similar to how they did for alerts_v2.go. But cloudauth also works. (as long as we don't change the name of the service).

@ravinadhruve10
Copy link
Contributor Author

Maybe we can use a cloudauth prefix instead of a v2 suffix across the board? E.g. name the file sysdig/internal/client/v2/cloudauth.go and the constants cloudauthAccountPath/cloudauthAccountsPath?

Seems a bit odd to add v2s across the board, especially when refering to an endpoint with v1 in it

Yes, that works too and that's a fair point. I named it with v2 as per the framework suggestion, similar to how they did for alerts_v2.go. But cloudauth also works. (as long as we don't change the name of the service).

Done!

@ravinadhruve10 ravinadhruve10 changed the base branch from master to feature/api-only-secure-onboarding September 6, 2023 22:13
@ravinadhruve10
Copy link
Contributor Author

All the latest changes are pulled and merged as part of #407 . Closing this PR then.

@tembleking tembleking deleted the feat/secure/cloudacc-client-v2 branch July 2, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants