From b28444999e0d7e3e6ae6c0e6ae859a2ccf5bb17e Mon Sep 17 00:00:00 2001 From: Eino Gourdin Date: Thu, 2 Feb 2023 15:38:00 +0100 Subject: [PATCH] feat: send default ping as comment message Send default ping payload as a comment line, as recommended by the RFC https://html.spec.whatwg.org/multipage/server-sent-events.html#authoring-notes Prevents some clients to raise an error when parsing the payload. --- sse_starlette/sse.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sse_starlette/sse.py b/sse_starlette/sse.py index f52b93a..ceb4460 100644 --- a/sse_starlette/sse.py +++ b/sse_starlette/sse.py @@ -257,7 +257,7 @@ async def _ping(self, send: Send) -> None: if self.ping_message_factory: assert isinstance(self.ping_message_factory, Callable) # type: ignore # https://github.com/python/mypy/issues/6864 ping = ( - ServerSentEvent(datetime.utcnow(), event="ping").encode() + ServerSentEvent(datetime.utcnow(), event=": ping").encode() if self.ping_message_factory is None else ensure_bytes(self.ping_message_factory()) )