Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_template_compile: rewrite test cases in criterion #2591

Merged

Conversation

@mehul-m-prajapati
Copy link
Contributor

commented Mar 4, 2019

fixes #2577

@kira-syslogng

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
do nothing -> CI won't start)

1 similar comment
@kira-syslogng

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
do nothing -> CI won't start)

@mehul-m-prajapati mehul-m-prajapati force-pushed the mehul-m-prajapati:test-template-compile-criterion branch from a759da5 to fdaebd4 Mar 4, 2019

@Kokan

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

@mehul-m-prajapati please solve the merge conflict

lib/template/tests/CMakeLists.txt Outdated Show resolved Hide resolved
@Kokan
Copy link
Contributor

left a comment

Please fix:

  • crash
  • cmake issue
  • merge conflict

@mehul-m-prajapati mehul-m-prajapati force-pushed the mehul-m-prajapati:test-template-compile-criterion branch 6 times, most recently from dee2d56 to 3ef04bb Mar 4, 2019

test_template_compile: rewrite test cases in criterion
Signed-off-by: Mehul Prajapati <mehul.encs@gmail.com>

@mehul-m-prajapati mehul-m-prajapati force-pushed the mehul-m-prajapati:test-template-compile-criterion branch from 3ef04bb to 51193c6 Mar 5, 2019

@Kokan Kokan added this to In progress in converting unit tests to criterion via automation Mar 5, 2019

@Kokan
Kokan approved these changes Mar 5, 2019

@Kokan Kokan moved this from In progress to Needs review in converting unit tests to criterion Mar 5, 2019

converting unit tests to criterion automation moved this from Needs review to Reviewer approved Mar 8, 2019

@MrAnno
MrAnno approved these changes Mar 8, 2019
@MrAnno

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Thanks!

@MrAnno MrAnno merged commit 2e8d25f into syslog-ng:master Mar 8, 2019

3 checks passed

LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

converting unit tests to criterion automation moved this from Reviewer approved to Done Mar 8, 2019

@mehul-m-prajapati mehul-m-prajapati deleted the mehul-m-prajapati:test-template-compile-criterion branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.