Repository navigation
Conversation
bazsi
force-pushed
the
accept-iso-timestamp-with-a-space-instead-of-T
branch
from
January 28, 2022 16:49
be8e5a5 to
9fea7c2
Compare
Contributor
|
Build SUCCESS |
This patch implements accepting ISO8601 timestamps with a space instead of a 'T' in the middle, as this format happens a lot in the wild. Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
force-pushed
the
accept-iso-timestamp-with-a-space-instead-of-T
branch
from
January 28, 2022 17:19
9fea7c2 to
3fcdfad
Compare
Collaborator
|
LGTM. Please add a news entry. |
Collaborator
Author
Probably MacOS has a different timezone and that test does not mock the timezone setting. I think the other testcase covers the parsing piece, so I've removed this failing testcase from test_msgparse. We still have one but that contains timezone That test_msgparse unit test is a dire need of a refactor...
I was about to. :) |
Collaborator
Yeah, that one is terrible. Sorry about that, I was lazy when I ported the test to Criterion :( |
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
MrAnno
approved these changes
Jan 28, 2022
Contributor
|
Build SUCCESS |
alltilla
approved these changes
Jan 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements accepting ISO8601 timestamps with a space instead of a 'T' in the middle, as this format happens a lot in the wild.
For instance ZScaler produces this syslog header:
The patch causes syslog-ng to accept this timestamp both in RFC5424 and RFC3164 mode. I've decided this way as even if we permitted the incorrect formatting only in RFC3164 mode, I expect the same to happen in 5424 implementations too. And I know it's against the spec, but this seems to be an uphill battle.