-
Notifications
You must be signed in to change notification settings - Fork 484
Add new TLS options sigalgs() and client-sigalgs() #4000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build SUCCESS |
Build SUCCESS |
This is a TLS extension specified by RFC5246: https://datatracker.ietf.org/doc/html/rfc5246#section-7.4.1.4.1 sigalgs: > This sets the supported signature algorithms for TLSv1.2 and TLSv1.3. > For clients this value is used directly for the supported signature > algorithms extension. For servers it is used to determine which > signature algorithms to support. client-sigalgs: > This sets the supported signature algorithms associated with client > authentication for TLSv1.2 and TLSv1.3. For servers the value is used > in the signature_algorithms field of a CertificateRequest message. > For clients it is used to determine which signature algorithm to use > with the client certificate. Signed-off-by: László Várady <laszlo.varady@protonmail.com>
This implements a TLS extension specified by RFC5246: https://datatracker.ietf.org/doc/html/rfc5246#section-7.4.1.4.1 Signed-off-by: László Várady <laszlo.varady@protonmail.com>
Signed-off-by: László Várady <laszlo.varady@protonmail.com>
Build SUCCESS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested:
Signature Hash Algorithms (2 algorithms)
Signature Algorithm: rsa_pss_rsae_sha256 (0x0804)
Signature Algorithm: ed25519 (0x0807)
@MrAnno @gaborznagy is this change applicable for MQTT TLS as well? |
Unfortunately, the MQTT source/destination uses a library ( |
How about supporting the ecdh-curve-list? I will follow up with paho separately. paho discussion: eclipse-paho/paho.mqtt.c#1226 |
The same is true for Supporting it in the HTTP destination is possible, let us know if you need it by opening a feature request . |
This PR adds 2 new TLS options, which make it possible to restrict which signature/hash pairs can be used in digital signatures.
This is a TLS extension specified by RFC5246:
https://datatracker.ietf.org/doc/html/rfc5246#section-7.4.1.4.1
sigalgs:
client-sigalgs:
Example config:
Partially resolves #3993