Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevshellPackages: Update to python3.11 #4107

Merged
merged 1 commit into from Aug 22, 2022

Conversation

mitzkia
Copy link
Collaborator

@mitzkia mitzkia commented Aug 18, 2022

Signed-off-by: Andras Mitzki andras.mitzki@quest.com

This PR tries to fix the issue related to building devshell image

@github-actions
Copy link
Contributor

No news file has been detected. Please write one, if applicable.

@mitzkia mitzkia changed the title DevshellPackages: Update for python3.11 DevshellPackages: Update to python3.11 Aug 18, 2022
@alltilla
Copy link
Collaborator

Can you please do a test run with the updated devshell image? Thanks!

@mitzkia
Copy link
Collaborator Author

mitzkia commented Aug 18, 2022

Of course, sure.

@gaborznagy
Copy link
Collaborator

I would squash the 2 commits into one, just like it was done originally in e61d4cf. It would show that these changes are related.

Otherwise, looks good to me!

@mitzkia
Copy link
Collaborator Author

mitzkia commented Aug 22, 2022

@gaborznagy Thanks for the review comments, I will squash the commits.

@mitzkia
Copy link
Collaborator Author

mitzkia commented Aug 22, 2022

I have run GitHub Actions jobs for the updated devshell image.
Here is the building of new devshell image into my fork (uploaded image id: 10ce80da):
https://github.com/mitzkia/syslog-ng/runs/7948340687?check_suite_focus=true

Here are the GithubActions CI runs (separate branch has been created for using proper devshell images from my fork):
https://github.com/mitzkia/syslog-ng/runs/7948535758?check_suite_focus=true

This is the raw output, where you can see the proper image (10ce80da) has been downloaded:
https://pipelines.actions.githubusercontent.com/serviceHosts/25ec8f32-2f66-4c50-8b65-b5e82d1abe70/_apis/pipelines/1/runs/3360/signedlogcontent/6?urlExpires=2022-08-22T09%3A59%3A35.4469786Z&urlSigningMethod=HMACV1&urlSignature=11KndbG%2FsPwFnoOx%2BAUxx9FOW2lBvsz4NefNZtnY0PQ%3D

I will rebase this PR to the master, to see the last unit-test failure (related to patterndb) has been fixed.

@mitzkia mitzkia marked this pull request as ready for review August 22, 2022 10:09
- python3.11-dev package required for installing psutil package with pip

Signed-off-by: Andras Mitzki <andras.mitzki@quest.com>
Copy link
Collaborator

@gaborznagy gaborznagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mitzkia !

@gaborznagy gaborznagy merged commit 10ff297 into syslog-ng:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants