Fix systemd journal hang when time is going backwards after a boot#4245
Merged
MrAnno merged 15 commits intosyslog-ng:masterfrom Jan 23, 2023
Conversation
Contributor
|
No news file has been detected. Please write one, if applicable. |
Contributor
|
Build FAILURE |
bazsi
force-pushed
the
fix-systemd-journal-hang-when-time-is-going-backwards-after-a-boot
branch
from
340f0dd to
7e79bc6
Compare
Contributor
|
Build FAILURE |
Collaborator
Author
|
This is not yet operational, sorry. I am still fighting with the unit test. |
Contributor
|
Build FAILURE |
bazsi
force-pushed
the
fix-systemd-journal-hang-when-time-is-going-backwards-after-a-boot
branch
from
333b333 to
f062198
Compare
Contributor
|
Build FAILURE |
bazsi
force-pushed
the
fix-systemd-journal-hang-when-time-is-going-backwards-after-a-boot
branch
from
f062198 to
1637615
Compare
bazsi
changed the title
Contributor
|
Build FAILURE |
bazsi
force-pushed
the
fix-systemd-journal-hang-when-time-is-going-backwards-after-a-boot
branch
from
1637615 to
f933714
Compare
Contributor
|
Build FAILURE |
Collaborator
|
@kira-syslogng retest this please |
We had typedefs and separate variables for various libsystemd related functions, remove the typedefs as that's a lot of boilerplate. Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
This patch still retains the capability for loading libsystemd.so at runtime, instead of linking to it specifically, but gets rid off a layer which does not really provide us too much value. Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
… Glibisms Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
…of the journal Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
…t boot This option is similar to "journalctl -b" which resolves an issue around clocks going backwards accross boots. Signed-off-by: @TaborKelly Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
bazsi
force-pushed
the
fix-systemd-journal-hang-when-time-is-going-backwards-after-a-boot
branch
from
f933714 to
29a2ca3
Compare
Collaborator
Author
|
added NEWS file, also updated the PR description to conclude on how we enable the new mode of operation. |
MrAnno
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch fixes #2836 in addition to much needed love to the systemd-journal() module.
It implements features, improves performance and code readability.
The match-boot() option will default to "yes" if you are using the system() source, "no" otherwise.
I worked from the patch provided by @TaborKelly originally but I am afraid most of his code will be completely eliminated by the time this is merged.
This needs some testing for sure, I am opening the PR to solicit feedback and to do that testing first, thus this is WIP.
@TaborKelly can you please check if this works for you? Thanks