add sdata-parser() & accept unquoted RFC5424 SD-PARAM-VALUE#4281
Merged
Conversation
Contributor
|
No news file has been detected. Please write one, if applicable. |
Contributor
|
Build FAILURE |
Contributor
|
Build FAILURE |
Contributor
|
Build FAILURE |
bazsi
force-pushed
the
sdata-parser
branch
2 times, most recently
from
3a77548 to
53a0bad
Compare
Contributor
|
Build FAILURE |
bazsi
changed the title
bazsi
force-pushed
the
sdata-parser
branch
2 times, most recently
from
4c50515 to
3b7f767
Compare
MrAnno
previously approved these changes
Feb 20, 2023
Contributor
|
Build FAILURE |
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
…_parse These functions were once part of the LogMessage object, long extracted, but the naming and argument lists still indicate their original location. This patch gets rid of the naming. Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
…og_format_parse_sd() Now with that function exposed to sdata-parser() do a stricter input validation, but relax the same as we are parsing SDATA as a part of RFC5424, as this was our historic behaviour. Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
As more and more vendors produce RFC5424, the number of them getting it wrong increases. Here's a vmware sample that we can't parse: <166>1 2023-01-09T22:12:56.677Z redacted.fqdn.invalid Hostd 2099364 - - [Originator@6876 sub=Vimsvc.ha-eventmgr opID=esxui-13c6-6b16 sid=5214bde6 user=root] Event 502 Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
MrAnno
approved these changes
Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows someone to incrementally parse a malformed RFC5424 message, where the SDATA portion is not at the right spot. The SDATA format is relatively complex, so extracting it as a separate component makes it easier to process this kind of data.
This is WIP, because: