systemd-journal: fix --with-systemd-journal=optional mode#4304
Merged
HofiOne merged 1 commit intoFeb 4, 2023
Merged
Conversation
Contributor
|
No news file has been detected. Please write one, if applicable. |
bazsi
reviewed
Feb 2, 2023
bazsi
previously approved these changes
Feb 2, 2023
Collaborator
bazsi
left a comment
bazsi
left a comment
There was a problem hiding this comment.
I am fine with this as is, I added a small improvement that would have made reviewing this easier but that's optional too.
With that change, this unit would be drastically more readable than it has been a month ago :)
Thanks
Further modifications in the lookup of sd_id128_XXX symbols (that can be presented in separate modules on some OSes e.g. Centos) Signed-off-by: Hofi <hofione@gmail.com>
HofiOne
force-pushed
the
Dynamic-loading-of-journald-symbols-fails-4300
branch
from
72c34ce to
67b9b41
Compare
Collaborator
Author
|
@bazsi Sorry, I've made a typo in libsystemd-id128.so.0, corrected, and added some logging of the lookup process and possible errors. Hope it's fine now. |
Collaborator
Author
|
Centos tests are passed too, seems we are fine now |
Collaborator
Author
|
@kira-syslogng retest this please; |
Collaborator
Author
|
@bazsi Could you please take a look at this one more (and hopefully the last time) again? |
bazsi
approved these changes
Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further modifications in the lookup of sd_id128_XXX symbols (that can be presented in separate modules on some OSes e.g. Centos)
Signed-off-by: Hofi hofione@gmail.com