New metric system (Prometheus data format)#4325
Merged
Merged
Conversation
Contributor
|
No news file has been detected. Please write one, if applicable. |
alltilla
reviewed
Feb 14, 2023
Collaborator
alltilla
left a comment
There was a problem hiding this comment.
Reviewed until stats: add labeling capability, inclusive. It looks good, I only had UT related comments.
I will check the last 2 commits soon.
8710521 to
6e6ce40
Compare
Contributor
|
Build FAILURE |
e24141b to
9c11d46
Compare
alltilla
reviewed
Feb 15, 2023
9c11d46 to
be7dcca
Compare
alltilla
reviewed
Feb 16, 2023
0ee8a78 to
95f2e77
Compare
Contributor
|
Build FAILURE |
95f2e77 to
476a1d2
Compare
Contributor
|
Build FAILURE |
187437d to
49891a2
Compare
a89d3a3 to
c5f98a4
Compare
Collaborator
Author
|
@kira-syslogng do stresstest |
Contributor
|
Kira-stress-test: Build FAILURE |
Collaborator
Author
|
@kira-syslogng do stresstest |
Collaborator
Author
|
@HofiOne Can you help us fix the stress test? 15:53:49 # An exception occured: https://ci.syslog-ng.com/jenkins/job/kira-performance-test-disk-buffer/645/console |
Contributor
|
Kira-stress-test: Build FAILURE |
Signed-off-by: László Várady <laszlo.varady@anno.io>
The CSV and log output are now considered legacy, stats-query can be used to display new "labeled" metrics. Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
This commit adds labels to stats cluster keys. These labels are similar to the labels in the Prometheus data model: https://prometheus.io/docs/concepts/data_model/ The (id, labels) pair identifies a new-style key. The order of the labels should not matter, and a label with an empty value should be equivalent to a label non-existing, but the current implementation is rudimentary and does not take these considerations into account. Signed-off-by: László Várady <laszlo.varady@anno.io>
To provide labels for individual counters within a cluster. Signed-off-by: László Várady <laszlo.varady@anno.io>
NOTE: Currently, it is not guaranteed that the message has reached its destination (the old name is misleading as well). Signed-off-by: László Várady <laszlo.varady@anno.io>
This helps creating legacy aliases for new metrics without adding a lot of boilerplate to the user side. Signed-off-by: László Várady <laszlo.varady@anno.io>
The new metric system requires metrics within the same cluster to have the same unit of measure. Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
sum(syslogng_output_events_total) wouldn't not be meaningful otherwise. Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
b5464f1 to
d33a548
Compare
Collaborator
Author
|
@kira-syslogng do stresstest |
Contributor
|
Kira-stress-test: Build SUCCESS |
alltilla
approved these changes
Feb 27, 2023
Genfood
pushed a commit
to Genfood/syslog-ng
that referenced
this pull request
Jun 14, 2023
Signed-off-by: László Várady <laszlo.varady@anno.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new metric naming scheme (labeling capability) to syslog-ng and a querying tool to produce Prometheus-like metric exports.
syslog-ng stats labels are similar to the labels in the Prometheus data model:
https://prometheus.io/docs/concepts/data_model/
The (id, labels) pair identifies a new-style key. The order of the labels
should not matter, and a label with an empty value should be equivalent to
a label non-existing, but the current implementation is rudimentary and
does not take these considerations into account.
The old (component, instance , id) keying is marked as
legacy; any of the legacy functions should not be used when introducing new metrics.Questions:
stats-log?Related PR: #4318