Skip to content

Fix memory leak in timeutils/cache (syslog-ng#4332)#4334

Merged
bazsi merged 1 commit into
syslog-ng:masterfrom
meeusr:memleak_fix2
Feb 22, 2023
Merged

Fix memory leak in timeutils/cache (syslog-ng#4332)#4334
bazsi merged 1 commit into
syslog-ng:masterfrom
meeusr:memleak_fix2

Conversation

@meeusr
Copy link
Copy Markdown

@meeusr meeusr commented Feb 17, 2023

Each time a worker thread terminates, the 2 allocated tznames are leaked. Solution is to explicitly deinit the cache from the stop function of the thread.

@kira-syslogng
Copy link
Copy Markdown
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

1 similar comment
@kira-syslogng
Copy link
Copy Markdown
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

@github-actions
Copy link
Copy Markdown
Contributor

No news file has been detected. Please write one, if applicable.

@bazsi
Copy link
Copy Markdown
Collaborator

bazsi commented Feb 17, 2023

Ok to test.

Each time a worker thread terminates, the 2 allocated tznames are
leaked. Solution is to explicitly deinit the cache from the stop
function of the thread.

Fixes: syslog-ng#4332

Signed-off-by: Ronny Meeus <ronny.meeus@nokia.com>
@bazsi bazsi merged commit ffb856c into syslog-ng:master Feb 22, 2023
MrAnno added a commit to MrAnno/syslog-ng that referenced this pull request Feb 28, 2023
Signed-off-by: László Várady <laszlo.varady@anno.io>
Genfood pushed a commit to Genfood/syslog-ng that referenced this pull request Jun 14, 2023
Signed-off-by: László Várady <laszlo.varady@anno.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants