Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not move throttled session to epoll #1952

Merged
merged 1 commit into from Mar 16, 2019

Conversation

@carsonip
Copy link
Contributor

@carsonip carsonip commented Mar 14, 2019

Epoll thread does not poll for EPOLLOUT. If a throttled session with
pending data out is moved to epoll thread, the session will stay in
epoll thread indefinitely, causing a hang observed by client. Fix by not
moving throttled session to epoll thread.

Fix #1939

Epoll thread does not poll for EPOLLOUT. If a throttled session with
pending data out is moved to epoll thread, the session will stay in
epoll thread indefinitely, causing a hang observed by client. Fix by not
moving throttled session to epoll thread.

Fix sysown#1939
@carsonip
Copy link
Contributor Author

@carsonip carsonip commented Mar 14, 2019

Don't merge first. I'll confirm whether this fixes #1939.

Loading

@pondix
Copy link
Contributor

@pondix pondix commented Mar 14, 2019

Automated message: PR pending admin approval for build testing

Loading

@carsonip
Copy link
Contributor Author

@carsonip carsonip commented Mar 15, 2019

@renecannao The fix works well. Please merge.

Loading

@renecannao renecannao merged commit b84271f into sysown:v2.0.3 Mar 16, 2019
@renecannao
Copy link
Contributor

@renecannao renecannao commented Mar 16, 2019

Thank you @carsonip !

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants