Improve HTTP server error handling and cleanup #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a single, well-defined cleanup path for the worker thread. On buffer allocation failure or receive errors, the code now frees the buffer, shuts down the socket, and propagates the original error back to the caller. The daemon also releases the socket when kthread creation fails. These adjustments prevent resource-leak scenarios and keep error codes intact, making the server more resilient to low-memory conditions and network-level faults.
|
Thank @Jordymalone for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a single, well-defined cleanup path for the worker thread. On buffer allocation failure or receive errors, the code now frees the buffer, shuts down the socket, and propagates the original error back to the caller. The daemon also releases the socket when kthread creation fails. These adjustments prevent resource-leak scenarios and keep error codes intact, making the server more resilient to low-memory conditions and network-level faults.