New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Fix 9 jsx-a11y console warnings #1126

Merged

hasparus merged 1 commit into system-ui:master from lachlanjc:reduce-warnings

Aug 12, 2020

Member

lachlanjc commented Aug 12, 2020

Working on the docs, 11 console warnings always print out, so this PR fixes 9 of them!

One remaining one is the events on noninteractive elements; I spent awhile researching & I can’t find a solution that doesn’t worsen accessibility to make the warning go away
The other remaining one seems to be a bug in the library, reporting that the <option> tags inside a <select> aren’t labeled (but they are)


          fix(docs): Fix 9 jsx-a11y console warnings

d2a09d5

hasparus approved these changes

View reviewed changes

Member

hasparus commented Aug 12, 2020

Nice one! I'll take the liberty of merging it.

hasparus merged commit 014030c into system-ui:master

lachlanjc deleted the reduce-warnings branch

August 14, 2020 00:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment