Skip to content

feat(color-modes): Default useColorModeMediaQuery to true - #1373

Merged
hasparus merged 3 commits into
system-ui:developfrom
lachlanjc:default-color-scheme-true
Dec 21, 2020
Merged

hasparus merged 3 commits into
system-ui:developfrom
lachlanjc:default-color-scheme-true

Conversation

@lachlanjc

Copy link
Copy Markdown
Member

Closes #624. Breaking change :)

@lachlanjc
lachlanjc requested a review from hasparus as a code owner December 16, 2020 19:52
@vercel

vercel Bot commented Dec 16, 2020 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/rc440pdje
✅ Preview: https://theme-ui-git-default-color-scheme-true.systemui.vercel.app

@hasparus hasparus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@hasparus
hasparus merged commit 4d67386 into system-ui:develop Dec 21, 2020
@lachlanjc
lachlanjc deleted the default-color-scheme-true branch December 21, 2020 16:05
@lachlanjc

Copy link
Copy Markdown
Member Author

Ok, so all the checks were passing here so I didn’t investigate further, but it looks like this broke some tests.

This branch was successfully deployed

1 active deployment
Preview — 9bf05e49 Deployed Dec 16, 2020 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default useColorSchemeMediaQuery to true

2 participants