components: Fix visual collapsing bug with Switch component #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/systemui/theme-ui/Bj8Mp5apecWfdDX4BFfTRtUra2aU |
hasparus
added
patch
This was referenced Jan 15, 2022
This was referenced Jan 29, 2022
This was referenced Feb 13, 2022
This was referenced Feb 20, 2022
This was referenced Mar 1, 2022
This was referenced Mar 16, 2022
|
🚀 PR was released in |
hasparus
added
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a bug with the Switch component where a long label or small container visually breaks it.
Before:
After:
📦 Published PR as canary version:
0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0✨ Test out this PR locally via:
npm install @theme-ui/color-modes@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/color@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/components@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/core@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/css@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/custom-properties@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/editor@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install gatsby-plugin-theme-ui@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install gatsby-theme-style-guide@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install gatsby-theme-ui-layout@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/match-media@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/mdx@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/parse-props@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/preset-base@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/preset-bootstrap@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/preset-bulma@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/preset-dark@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/preset-deep@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/preset-funk@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/preset-future@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/preset-polaris@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/preset-roboto@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/preset-sketchy@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/preset-swiss@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/preset-system@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/preset-tailwind@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/preset-tosh@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/presets@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/prism@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/sidenav@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/style-guide@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/tailwind@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/theme-provider@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install theme-ui@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 npm install @theme-ui/typography@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 # or yarn add @theme-ui/color-modes@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/color@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/components@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/core@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/css@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/custom-properties@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/editor@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add gatsby-plugin-theme-ui@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add gatsby-theme-style-guide@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add gatsby-theme-ui-layout@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/match-media@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/mdx@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/parse-props@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/preset-base@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/preset-bootstrap@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/preset-bulma@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/preset-dark@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/preset-deep@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/preset-funk@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/preset-future@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/preset-polaris@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/preset-roboto@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/preset-sketchy@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/preset-swiss@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/preset-system@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/preset-tailwind@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/preset-tosh@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/presets@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/prism@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/sidenav@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/style-guide@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/tailwind@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/theme-provider@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add theme-ui@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0 yarn add @theme-ui/typography@0.13.2--canary.2067.2ad0fafad83e0b366ed7a4456d67deb1ddab0942.0