Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkosi: generate default UTF-8 locale for Arch Linux #187

Merged
merged 1 commit into from Nov 14, 2017

Conversation

@johnlinp
Copy link
Contributor

@johnlinp johnlinp commented Nov 2, 2017

Fixes: #186

@poettering
Copy link
Member

@poettering poettering commented Nov 8, 2017

grrr. A pity that arch doesn't get this right out-of-the-box

Loading

@poettering
Copy link
Member

@poettering poettering commented Nov 8, 2017

hmm, this approach leaves locale-gen.service around in the image. I'd prefer if we didn't. Can't we instead just invoke localegen through nspawn, after running the package manager?

Loading

@johnlinp
Copy link
Contributor Author

@johnlinp johnlinp commented Nov 9, 2017

@poettering Thank you for the comments. I will work on it.

Loading

@johnlinp johnlinp force-pushed the fix-locale-gen branch from bd22d6c to 45f9c03 Nov 9, 2017
@johnlinp
Copy link
Contributor Author

@johnlinp johnlinp commented Nov 9, 2017

In the new patch, I use run_workspace_command() to execute locale-gen instead of creating a service unit. Please take a look at it. Thanks.

Loading

@keszybz keszybz merged commit 0dc40f4 into systemd:master Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants