Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): add shell linter - Differential ShellCheck #529

Merged
merged 1 commit into from Aug 16, 2022
Merged

ci(lint): add shell linter - Differential ShellCheck #529

merged 1 commit into from Aug 16, 2022

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Aug 16, 2022

Differential ShellCheck is a GitHub action that performs differential ShellCheck scans on shell scripts changed via PR and reports results directly in PR.

I saw that your scripts are in great shape and that you already have shell linter in place, but I still think that you might find differential-shellcheck action useful. It is able to produce reports in SARIF format, GitHub understands this format and is able to display it nicely as PR comment and on the Files Changed tab, please see below.

image

image

Documentation is available at @redhat-plumbers-in-action/differential-shellcheck. Let me know If you are missing some feature or setting. I'm always happy to extend functionality.

/cc @mrc0mmand

It performs differential ShellCheck scans and report results directly in
pull request.

documentation:
https://github.com/redhat-plumbers-in-action/differential-shellcheck
common/task-control.sh Fixed Show fixed Hide fixed
common/task-control.sh Fixed Show fixed Hide fixed
common/task-control.sh Fixed Show fixed Hide fixed
common/task-control.sh Fixed Show fixed Hide fixed
vagrant/vagrant-build.sh Fixed Show fixed Hide fixed
Copy link
Member

@mrc0mmand mrc0mmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nifty, thank you!

@mrc0mmand mrc0mmand merged commit 6c33742 into systemd:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants