Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-catalog does not work as installed test as it hard-codes CATALOG_DIR #10045

Closed
mbiebl opened this issue Sep 10, 2018 · 1 comment
Closed
Labels

Comments

@mbiebl
Copy link
Contributor

mbiebl commented Sep 10, 2018

test-catalog uses

         '', '', '-DCATALOG_DIR="@0@"'.format(build_catalog_dir)],

This absolute path is embedded into the binary. As a result, it does not really work as an installed test and the binary simply abort with an assertion when run from /usr/lib/systemd/tests/
Another side effect is, that it trips up our reproducibility checks in Debian. See
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908365#25

Given that, should we stop installing test-catalog or is there a way to avoid encoding an absolute path in the binary and make it also work when installed?

@yuwata
Copy link
Member

yuwata commented Sep 10, 2018

Please test #10046.

yuwata added a commit to yuwata/systemd that referenced this issue Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants