Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibreSSL support #14928

Closed
mikken opened this issue Feb 23, 2020 · 7 comments
Closed

LibreSSL support #14928

mikken opened this issue Feb 23, 2020 · 7 comments

Comments

@mikken
Copy link

mikken commented Feb 23, 2020

systemd version the issue has been seen with

245

Used distribution

Gentoo

This is the error during build:

../systemd-245-rc1/src/home/homed-manager.c: In function ‘manager_generate_key_pair’:
../systemd-245-rc1/src/home/homed-manager.c:1292:35: error: ‘EVP_PKEY_ED25519’ undeclared (first use in this function); did you mean ‘EVP_PKEY_DSA1’?
 1292 |         ctx = EVP_PKEY_CTX_new_id(EVP_PKEY_ED25519, NULL);
      |                                   ^~~~~~~~~~~~~~~~
      |                                   EVP_PKEY_DSA1
../systemd-245-rc1/src/home/homed-manager.c:1292:35: note: each undeclared identifier is reported only once for each function it appears in
ninja: build stopped: subcommand failed.

evp.h in current LibreSSL 3.0.2 does not have this define (EVP_PKEY_ED25519).

@zdzichu
Copy link
Contributor

zdzichu commented Feb 24, 2020

Why not fix LibreSSL by adding such key types?

@mikken
Copy link
Author

mikken commented Feb 24, 2020

I'll check with them in the mailing list.

@poettering
Copy link
Member

Ed25519 is not particularly exotic, in particular not in the OpenBSD world (signify uses it) where LibreSSL comes from... THey really should add that, and we cannot work around it really, and shouldn't.

Sorry, but this is a feature request to make to the LibreSSL people, not us. Sorry!

@mikken
Copy link
Author

mikken commented Apr 1, 2020

It's okay, I asked in LibreSSL mailing list, they plan to implement this later.

@mikken
Copy link
Author

mikken commented May 20, 2020

Note: with current LibreSSL 3.1.1 this is fixed.

@ffontaine
Copy link
Contributor

systemd 250.4 is still failing to build with libressl 3.4.3:

../src/home/homed-manager.c: In function ‘manager_generate_key_pair’:
../src/home/homed-manager.c:1393:35: error: ‘EVP_PKEY_ED25519’ undeclared (first use in this function); did you mean ‘EVP_PKEY_DSA1’?
 1393 |         ctx = EVP_PKEY_CTX_new_id(EVP_PKEY_ED25519, NULL);
      |                                   ^~~~~~~~~~~~~~~~
      |                                   EVP_PKEY_DSA1

Moreover, I wasn't able to find any mention of EVP_PKEY_ED25519 in https://github.com/libressl-portable/portable or https://github.com/libressl-portable/openbsd.

Should I disable systemd with libressl on buildroot side?

Full build log: http://autobuild.buildroot.org/results/47f/47f31b36f123c4be4661f4fde2d1f7385c5d0ed5/build-end.log

@mrc0mmand
Copy link
Member

It looks like ED25519 stuff is not yet in libressl judging by libressl/portable#393? I guess pinging the libressl folks about this should help, there's not much we can do anyway.

Should I disable systemd with libressl on buildroot side?

Ideally we should keep it, but there's no point in having a constantly failing job wasting resources if this doesn't get addressed.

buildroot-auto-update pushed a commit to buildroot/buildroot that referenced this issue Apr 14, 2022
systemd doesn't plan to fix the following build failure with libressl
(systemd/systemd#14928) and ED25519 support
is still not available in libressl
(libressl/portable#393 opened for
more than 3 years):

../src/home/homed-manager.c: In function ‘manager_generate_key_pair’:
../src/home/homed-manager.c:1393:35: error: ‘EVP_PKEY_ED25519’ undeclared (first use in this function); did you mean ‘EVP_PKEY_DSA1’?
 1393 |         ctx = EVP_PKEY_CTX_new_id(EVP_PKEY_ED25519, NULL);
      |                                   ^~~~~~~~~~~~~~~~
      |                                   EVP_PKEY_DSA1

Fixes:
 - http://autobuild.buildroot.org/results/47f31b36f123c4be4661f4fde2d1f7385c5d0ed5

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
buildroot-auto-update pushed a commit to buildroot/buildroot that referenced this issue May 8, 2022
systemd doesn't plan to fix the following build failure with libressl
(systemd/systemd#14928) and ED25519 support
is still not available in libressl
(libressl/portable#393 opened for
more than 3 years):

../src/home/homed-manager.c: In function ‘manager_generate_key_pair’:
../src/home/homed-manager.c:1393:35: error: ‘EVP_PKEY_ED25519’ undeclared (first use in this function); did you mean ‘EVP_PKEY_DSA1’?
 1393 |         ctx = EVP_PKEY_CTX_new_id(EVP_PKEY_ED25519, NULL);
      |                                   ^~~~~~~~~~~~~~~~
      |                                   EVP_PKEY_DSA1

Fixes:
 - http://autobuild.buildroot.org/results/47f31b36f123c4be4661f4fde2d1f7385c5d0ed5

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
(cherry picked from commit 1c79d64)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
spockfish pushed a commit to RoPieee/buildroot that referenced this issue May 9, 2022
systemd doesn't plan to fix the following build failure with libressl
(systemd/systemd#14928) and ED25519 support
is still not available in libressl
(libressl/portable#393 opened for
more than 3 years):

../src/home/homed-manager.c: In function ‘manager_generate_key_pair’:
../src/home/homed-manager.c:1393:35: error: ‘EVP_PKEY_ED25519’ undeclared (first use in this function); did you mean ‘EVP_PKEY_DSA1’?
 1393 |         ctx = EVP_PKEY_CTX_new_id(EVP_PKEY_ED25519, NULL);
      |                                   ^~~~~~~~~~~~~~~~
      |                                   EVP_PKEY_DSA1

Fixes:
 - http://autobuild.buildroot.org/results/47f31b36f123c4be4661f4fde2d1f7385c5d0ed5

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
(cherry picked from commit 1c79d64)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants