Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: support for long unit names #18077

Closed
DemiMarie opened this issue Dec 24, 2020 · 2 comments · Fixed by #22759
Closed

RFE: support for long unit names #18077

DemiMarie opened this issue Dec 24, 2020 · 2 comments · Fixed by #22759
Assignees
@msekletar
Labels
downstream/rhel Tracking bugs for RHEL pid1 RFE 🎁 Request for Enhancement, i.e. a feature request

Comments

@DemiMarie
Copy link

Is your feature request related to a problem? Please describe.
systemd currently has a hard limit of 255 bytes for the length of a unit name. This causes problems such as #17684.

Describe the solution you'd like
Longer unit names are supported. This can be done by hashing them before converting them to a filename.

Describe alternatives you've considered
Long mount point paths could be handled differently. For instance, they could be symlinked to somewhere under /run.
@poettering poettering added pid1 RFE 🎁 Request for Enhancement, i.e. a feature request labels Jan 6, 2021
@lnykryn lnykryn added the downstream/rhel Tracking bugs for RHEL label Apr 19, 2021
@keszybz
Copy link
Member

keszybz commented Jun 1, 2021

https://bugzilla.redhat.com/show_bug.cgi?id=1779813

@keszybz keszybz added this to the v249 milestone Jun 1, 2021
@poettering
Copy link
Member

Unsetting milestone again. I think #17684 + #16161 should be enough to have on the milestone.

@poettering poettering removed this from the v249 milestone Jun 1, 2021
msekletar added a commit to msekletar/systemd that referenced this issue Jan 14, 2022
@msekletar
unit: replace static UNIT_NAME_MAX with version that depends on unit …
66a208d 
…type

Fixes systemd#18077
msekletar added a commit to msekletar/systemd that referenced this issue Jan 27, 2022
@msekletar
unit: replace static UNIT_NAME_MAX with version that depends on unit …
29fbfa5 
…type

Fixes systemd#18077
msekletar added a commit to msekletar/systemd that referenced this issue Feb 4, 2022
@msekletar
core: make it possible to have per unit type name length limit
68ae14d 
Fixes systemd#18077
msekletar added a commit to msekletar/systemd that referenced this issue Mar 15, 2022
@msekletar
core: shorten long unit names that are based on paths and append path…
295ae2f 
… hash at the end

Fixes systemd#18077
@msekletar msekletar mentioned this issue Mar 15, 2022
Merged
msekletar added a commit to msekletar/systemd that referenced this issue Mar 16, 2022
@msekletar
core: shorten long unit names that are based on paths and append path…
141dbe9 
… hash at the end

Fixes systemd#18077
msekletar added a commit to msekletar/systemd that referenced this issue Mar 23, 2022
@msekletar
core: shorten long unit names that are based on paths and append path…
67db1c8 
… hash at the end

Fixes systemd#18077
msekletar added a commit to msekletar/systemd that referenced this issue Mar 23, 2022
@msekletar
core: shorten long unit names that are based on paths and append path…
0eb4d0d 
… hash at the end

Fixes systemd#18077
msekletar added a commit to msekletar/systemd that referenced this issue Mar 23, 2022
@msekletar
core: shorten long unit names that are based on paths and append path…
bf15260 
… hash at the end

Fixes systemd#18077
msekletar added a commit to msekletar/systemd that referenced this issue Mar 24, 2022
@msekletar
core: shorten long unit names that are based on paths and append path…
e6cbeff 
… hash at the end

Fixes systemd#18077
msekletar added a commit to msekletar/systemd that referenced this issue Mar 28, 2022
@msekletar
core: shorten long unit names that are based on paths and append path…
67594fc 
… hash at the end

Fixes systemd#18077
msekletar added a commit to msekletar/systemd that referenced this issue Apr 8, 2022
@msekletar
core: shorten long unit names that are based on paths and append path…
28d41c7 
… hash at the end

Fixes systemd#18077
msekletar added a commit to msekletar/systemd that referenced this issue Apr 8, 2022
@msekletar
core: shorten long unit names that are based on paths and append path…
1d0727e 
… hash at the end

Fixes systemd#18077
@Madhu-1 Madhu-1 mentioned this issue Jan 23, 2023
Closed
Werkov pushed a commit to Werkov/systemd that referenced this issue Nov 1, 2023
@msekletar @fbuihuu
core: shorten long unit names that are based on paths and append path…
3f84b06 
… hash at the end

Fixes systemd#18077

(cherry picked from commit 1d0727e)

[fbui: adjust context]
[fbui: fixes bsc#1208194]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msekletar msekletar

Labels
downstream/rhel Tracking bugs for RHEL pid1 RFE 🎁 Request for Enhancement, i.e. a feature request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create "hashed" unit names from long paths msekletar/systemd
5 participants
@keszybz @msekletar @lnykryn @poettering @DemiMarie