-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting DuplicateAddressDetection=none doesn't disable DAD for link-local IPs #22763
Comments
|
This is intended change by 1cf4ed1. |
|
Maybe, if |
|
No issue except for the failure described above. I understand that this change was intended by 1cf4ed1 but I think the behavior is confusing, as it ignores/overrides explicit user configuration.
ACK. |
…etection= Background: Setting `DuplicateAddressDetection=ipv4` is meaningless for IPv6 addresses. Similary, `DuplicateAddressDetection=ipv6` is meaningless for IPv4 addresses. Hence, setting boolean value is enough. However, very unfortunately, the setting was implemented so badly, and we cannot use boolean string for the setting without breaking backward compatibility. See config_parse_duplicate_address_detection(). Solution: Hence, this deprecates DuplicateAddressDetection= and re-implement similar setting EnableDuplicateAddressDetection=, which only takes boolean string. Justification: The naming is slightly redundant, but should not introduce any confusions. Also, we did similar change for another unfortunate situation in PrefixRoute=, and the setting was renamed PrefixRoute= -> AddPrefixRoute=. This also changes that the IPv4 ACD is enabled for IPv4 link-local addresses only when it is not explicitly disabled. Fixes systemd#22763.
… disabled explicitly Fixes systemd#22763.
… disabled explicitly The commit 1cf4ed1 makes the IPv4 ACD enabled unconditionally for IPv4 link-local addresses even if users explicitly disable ACD. This makes the IPv4 ACD is enabled by default, but honor user setting. Fixes systemd#22763.
|
Thank you very much! 👏 |
… disabled explicitly The commit 1cf4ed1 makes the IPv4 ACD enabled unconditionally for IPv4 link-local addresses even if users explicitly disable ACD. This makes the IPv4 ACD is enabled by default, but honor user setting. Fixes systemd#22763.
Our configuration with the static IPv4 fallback address suffers from the following upstream regression in systemd v250: systemd/systemd#22763 This is a backport of the corresponding fix. It also disables DAD for the fallback IP address, otherwise it might be removed when a second device is detected. While this should be re-considered later, this restores the current/older behavior for now. Signed-off-by: Michael Heimpold <michael.heimpold@in-tech.com>
Our configuration with the static IPv4 fallback address suffers from the following upstream regression in systemd v250: systemd/systemd#22763 This is a backport of the corresponding fix. It also disables DAD for the fallback IP address, otherwise it might be removed when a second device is detected. While this should be re-considered later, this restores the current/older behavior for now. Signed-off-by: Michael Heimpold <michael.heimpold@in-tech.com>
… disabled explicitly The commit 1cf4ed1 makes the IPv4 ACD enabled unconditionally for IPv4 link-local addresses even if users explicitly disable ACD. This makes the IPv4 ACD is enabled by default, but honor user setting. Fixes systemd#22763. (cherry picked from commit 2859932)
… disabled explicitly The commit 1cf4ed1 makes the IPv4 ACD enabled unconditionally for IPv4 link-local addresses even if users explicitly disable ACD. This makes the IPv4 ACD is enabled by default, but honor user setting. Fixes systemd#22763. (cherry picked from commit 2859932)
systemd version the issue has been seen with
Used distribution
Linux kernel version used (
uname -a)CPU architecture issue was seen on
Expected behaviour you didn't see
Unexpected behaviour you saw
Steps to reproduce the problem
Additional program output to the terminal or log subsystem illustrating the issue
Forwarded from: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1964494
The text was updated successfully, but these errors were encountered: