Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network-generator: split out udev pieces from systemd-network-generator #27945

Open
dustymabe opened this issue Jun 6, 2023 · 4 comments
Open
Labels
needs-discussion 🤔 network RFE 🎁 Request for Enhancement, i.e. a feature request

Comments

@dustymabe
Copy link

dustymabe commented Jun 6, 2023

Component

systemd-network-generator

Is your feature request related to a problem? Please describe

The udev pieces of systemd-network-generator are useful even if you aren't using systemd-networkd on your system (i.e. using NetworkManager, or other). It's mostly harmless to have systemd-network-generator to generate networking configuration if the sytsemd-networkd isn't enabled, but it is misleading:

This is a continuation of the discussion in #21766 (comment)

Describe the solution you'd like

Break out the udev pieces into a new service that can operate independently of systemd-networkd.

Describe alternatives you've considered

Leaving it like it is today. Sure failures are cosmetic, but ultimately the design would be better if these two things that are responsible for different pieces were independent.

The systemd version you checked that didn't have the feature you are asking for

No response

@dustymabe dustymabe added the RFE 🎁 Request for Enhancement, i.e. a feature request label Jun 6, 2023
@dustymabe
Copy link
Author

can someone please add the network label to this? Sorry I missed the Component when I first opened the issue.

@keszybz
Copy link
Member

keszybz commented Jun 7, 2023

We could do the split only at installation level: e.g. make systemd-network-generator a multi-call binary, and only write out the link files from systemd-link-generator. If we do this, I think this would be most reasonable way.

There is a non-negligible cost to splitting things into tiny bits. Mostly when all the bits are used together: things are a bit slower, there's bigger chances of missing some integration, etc. If the are some warning emitted during parsing, both generators would emit them. OTOH, the additional cost of writing a few network files if they are not used is negligible.

So I would lean towards just fixing any bugs which cause warnings to be emitted. We want and need to fix those, and then the motivation for this RFE is mostly removed.

@poettering
Copy link
Member

humpf. should we really bother with this? if people don't want networkd, great, but then they should carry the burden for that, and reimplement network management as they see fit themselves.

(Also, I mean, in general in 2023, does anyone still really want to use NM? isn't this over now in the cloud?)

@keszybz
Copy link
Member

keszybz commented Jun 7, 2023

I'm pretty sure we should. NM is alive and well, and there are also other approaches that people use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-discussion 🤔 network RFE 🎁 Request for Enhancement, i.e. a feature request
Development

No branches or pull requests

4 participants