Something went wrong with that request. Please try again.

[cinquecento]

[poettering]

@dvdhrm i think this is something you changed? could you comment?

[dvdhrm]

On it, see the discussion on the ML. Problem is, reverting the initial patch breaks --user units. I couldn't reproduce it, yet. Lets see whether tomorrow will make things better.

[poettering]

How does this one relate to #513? Should that issue be closed in favour of this one?

[dvdhrm]

I assume it's the same issue.

[dvdhrm]

...lightdm doesn't even set XDG_SESSION_CLASS. Meh.

Which makes we wonder, why my first patch improved the situation for you?

[dvdhrm]

Reading your last reply: It seems this is rather randomly working for you, right?

(I really appreciate your many logs, but it's hard to find a description of the problem in your own words ;))

[dvdhrm]

Weird. If I run lightdm, then loginctl show-session $sid does not show class=greeter, but class=user.

[dvdhrm]

On top of systemd-git:

(EDITED: see next comment)

I hope this fixes your issues.

[dvdhrm]

Sorry, I stripped the interesting parts.. let's try it again:

This on top of systemd-git fixes all issues for me:

diff --git a/src/login/logind-seat.c b/src/login/logind-seat.c
index 9d5287a..904bee3 100644
--- a/src/login/logind-seat.c
+++ b/src/login/logind-seat.c
@@ -471,7 +471,6 @@ int seat_stop_sessions(Seat *s, bool force) {
 }

 void seat_evict_position(Seat *s, Session *session) {
-        Session *iter;
         unsigned int pos = session->position;

         session->position = 0;
@@ -479,19 +478,8 @@ void seat_evict_position(Seat *s, Session *session) {
         if (pos == 0)
                 return;

-        if (pos < s->position_count && s->positions[pos] == session) {
+        if (pos < s->position_count && s->positions[pos] == session)
                 s->positions[pos] = NULL;
-
-                /* There might be another session claiming the same
-                 * position (eg., during gdm->session transition), so let's look
-                 * for it and set it on the free slot. */
-                LIST_FOREACH(sessions_by_seat, iter, s->sessions) {
-                        if (iter->position == pos) {
-                                s->positions[pos] = iter;
-                                break;
-                        }
-                }
-        }
 }

 void seat_claim_position(Seat *s, Session *session, unsigned int pos) {
@@ -505,7 +493,7 @@ void seat_claim_position(Seat *s, Session *session, unsigned int pos) {
         seat_evict_position(s, session);

         session->position = pos;
-        if (pos > 0 && !s->positions[pos])
+        if (pos > 0)
                 s->positions[pos] = session;
 }

[dvdhrm]

So, I really want to track this down. With my fix I posted earlier, everything works for me. And as you said, you see the issue only if run as live-cd-style-distro. Attached is a patch that should print sufficient debug-information (as LOG_ERROR) for me to trace what happens on your machine. Can you try running this?

I'd also appreciate if you can show me how to reproduce the issue. What exactly is different in your liveCD setup? Why does it only happen there? Do you run older lightdm version there?

diff --git a/src/login/logind-dbus.c b/src/login/logind-dbus.c
index 82654ee..1459952 100644
--- a/src/login/logind-dbus.c
+++ b/src/login/logind-dbus.c
@@ -701,7 +701,8 @@ static int method_create_session(sd_bus_message *message, void *userdata, sd_bus
          * backwards-compatibility, so make sure we allow new sessions
          * on a VT that a greeter is running on.
          */
-        if (vtnr > 0 &&
+        if (c != SESSION_GREETER &&
+            vtnr > 0 &&
             vtnr < m->seat0->position_count &&
             m->seat0->positions[vtnr] &&
             m->seat0->positions[vtnr]->class != SESSION_GREETER)
diff --git a/src/login/logind-seat.c b/src/login/logind-seat.c
index fb5d076..57f5209 100644
--- a/src/login/logind-seat.c
+++ b/src/login/logind-seat.c
@@ -481,16 +481,6 @@ void seat_evict_position(Seat *s, Session *session) {

         if (pos < s->position_count && s->positions[pos] == session) {
                 s->positions[pos] = NULL;
-
-                /* There might be another session claiming the same
-                 * position (eg., during gdm->session transition), so let's look
-                 * for it and set it on the free slot. */
-                LIST_FOREACH(sessions_by_seat, iter, s->sessions) {
-                        if (iter->pos == pos) {
-                                s->positions[pos] = iter;
-                                break;
-                        }
-                }
         }
 }

@@ -505,7 +495,7 @@ void seat_claim_position(Seat *s, Session *session, unsigned int pos) {
         seat_evict_position(s, session);

         session->pos = pos;
-        if (pos > 0 && !s->positions[pos])
+        if (pos > 0)
                 s->positions[pos] = session;
 }

diff --git a/src/login/pam_systemd.c b/src/login/pam_systemd.c
index f83d18b..21bd57e 100644
--- a/src/login/pam_systemd.c
+++ b/src/login/pam_systemd.c
@@ -368,8 +368,8 @@ _public_ PAM_EXTERN int pam_sm_open_session(
                 return PAM_SESSION_ERR;
         }

-        if (debug)
-                pam_syslog(handle, LOG_DEBUG, "Asking logind to create session: "
+        if (debug || 1)
+                pam_syslog(handle, LOG_ERR, "Asking logind to create session: "
                            "uid="UID_FMT" pid="PID_FMT" service=%s type=%s class=%s desktop=%s seat=%s vtnr=%"PRIu32" tty=%s display=%s remote=%s remote_user=%s remote_host=%s",
                            pw->pw_uid, getpid(),
                            strempty(service),
@@ -399,6 +399,7 @@ _public_ PAM_EXTERN int pam_sm_open_session(
                                remote_user,
                                remote_host,
                                0);
+        pam_syslog(handle, LOG_ERR, "Create session (%d): %s", r, bus_error_message(&error, r));
         if (r < 0) {
                 if (sd_bus_error_has_name(&error, BUS_ERROR_SESSION_BUSY)) {
                         pam_syslog(handle, LOG_DEBUG, "Cannot create session: %s", bus_error_message(&error, r));