/systemd

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segfault on systemctl enable|is-enabled with zero-length unit arg #5483

Closed
absurd34 opened this Issue Feb 28, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
Milestone
  v233
2 participants
@absurd34 @poettering
@absurd34

absurd34 commented Feb 28, 2017 •
edited
Edited 1 time
  • @absurd34 absurd34 edited Feb 28, 2017 (most recent)

Submission type

  • Bug report
  • Request for enhancement (RFE)

NOTE: Do not submit anything other than bug reports or RFEs via the issue tracker!

systemd version the issue has been seen with

230, 232

NOTE: Do not submit bug reports about anything but the two most recently released systemd versions upstream!

Used distribution

Debian

In case of bug report: Expected behaviour you didn't see

Some invalid argument error handling.

In case of bug report: Unexpected behaviour you saw

segfault

In case of bug report: Steps to reproduce the problem

systemctl enable ''
systemctl is-enabled ''

fwiw, I get this on a current Debian sid (systemd 232):

$ absurd? systemctl enable ''
*** Error in `systemctl': free(): invalid pointer: 0x00007f5f19beeb58 ***
======= Backtrace: =========
/lib/x86_64-linux-gnu/libc.so.6(+0x70bcb)[0x7f5f198c6bcb]
/lib/x86_64-linux-gnu/libc.so.6(+0x76f96)[0x7f5f198ccf96]
/lib/x86_64-linux-gnu/libc.so.6(+0x7778e)[0x7f5f198cd78e]
/lib/systemd/libsystemd-shared-232.so(strv_clear+0x29)[0x7f5f19f0a9b9]
/lib/systemd/libsystemd-shared-232.so(strv_free+0x9)[0x7f5f19efa839]
systemctl(+0x15b95)[0x7f5f1a46eb95]
systemctl(+0x164f0)[0x7f5f1a46f4f0]
/lib/systemd/libsystemd-shared-232.so(dispatch_verb+0x20d)[0x7f5f19ef101d]
systemctl(+0x7d5b)[0x7f5f1a460d5b]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1)[0x7f5f198762b1]
systemctl(+0x99ba)[0x7f5f1a4629ba]

Thx!

S

@poettering poettering added systemctl bug 🐛 labels Feb 28, 2017

@poettering poettering added this to the v233 milestone Feb 28, 2017

poettering added a commit to poettering/systemd that referenced this issue Feb 28, 2017

@poettering
systemctl: fix bad memory access when mangle_names() fails 
Fixes: #5483
6bfedb2

@poettering poettering referenced this issue Feb 28, 2017

Merged

systemctl: fix bad memory access when mangle_names() fails #5485

@poettering poettering added the has-pr ✨ label Feb 28, 2017

@poettering

This comment has been minimized.

Show comment
Hide comment
@poettering

poettering Feb 28, 2017

Member

Fix waiting in #5485
Member

poettering commented Feb 28, 2017

Fix waiting in #5485
@absurd34

This comment has been minimized.

Show comment
Hide comment
@absurd34

absurd34 Feb 28, 2017

Thx Lennart!

absurd34 commented Feb 28, 2017

Thx Lennart!

@martinpitt martinpitt closed this in #5485 Feb 28, 2017

martinpitt added a commit that referenced this issue Feb 28, 2017

@poettering @martinpitt
systemctl: fix bad memory access when mangle_names() fails (#5485) 
Fixes #5483
523f8cd

@evverx evverx referenced this issue Mar 10, 2017

Closed

crash when running systemctl is-enabled '' (empty argument) #5566

1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment