New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core, sysctl: skip ENOENT for /proc/sys/net/unix/max_dgram_qlen #10646

Merged
merged 1 commit into from Nov 6, 2018

Conversation

3 participants
@giuseppe
Contributor

giuseppe commented Nov 5, 2018

sysctl is disabled for /proc mounted from an user namespace thus entries like
/proc/sys/net/unix/max_dgram_qlen do not exist. In this case, skip the error
and do not try to change the default for the AF_UNIX datagram queue length.

/proc/sys/net/unix/max_dgram_qlen is disabled for unprivileged users in the
kernel here:

https://github.com/torvalds/linux/blob/master/net/unix/sysctl_net_unix.c#L37-L39

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

Show resolved Hide resolved src/core/main.c Outdated
Show resolved Hide resolved src/core/main.c Outdated
core, sysctl: skip ENOENT for /proc/sys/net/unix/max_dgram_qlen
sysctl is disabled for /proc mounted from an user namespace thus entries like
/proc/sys/net/unix/max_dgram_qlen do not exist.  In this case, skip the error
and do not try to change the default for the AF_UNIX datagram queue length.

@giuseppe giuseppe force-pushed the giuseppe:rootless-no-sysctl branch from 95e42a6 to 2d98e1c Nov 6, 2018

@poettering poettering merged commit 875622c into systemd:master Nov 6, 2018

5 of 7 checks passed

bionic-arm64 autopkgtest finished (failure)
Details
bionic-i386 autopkgtest running
Details
LGTM analysis: C/C++ No alert changes
Details
LGTM analysis: JavaScript No code changes detected
Details
bionic-amd64 autopkgtest finished (success)
Details
bionic-s390x autopkgtest finished (success)
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment