Drop unused atomic operations #11888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly cosmetic. It makes those test binaries support SYSTEMD_LOG_* environment variables.
We had atomic counters, but all other operations were non-serialized. This means that concurrent access to the bus object was only safe if _all_ threads were doing read-only access. Even sending of messages from threads would not be possible, because after sending of the message we usually want to remove it from the send queue in the bus object, which would race. Let's just kill this.
The sd-hwdb objects cannot be used concurrently from two threads in any meaningful way, because query and iteration operations modify the object. Thus atomic reference counts are pointless.
Same as with the other users, any non-trivial use of the objects requires use from a single thread only or external locking. Using atomic operations just for reference counts is not useful.
poettering
reviewed
Mar 4, 2019
src/libsystemd/sd-hwdb/sd-hwdb.c
Outdated
| return log_debug_errno(errno, "Failed to read %s: %m", hwdb_bin_path); | ||
| if (fstat(fileno(hwdb->f), &hwdb->st) < 0) | ||
| return log_debug_errno(errno, "Failed to stat %s: %m", hwdb_bin_path); | ||
| if ((size_t) hwdb->st.st_size < offsetof(struct trie_header_f, strings_len) + 8) |
There was a problem hiding this comment.
this size check is weird btw, and I think should be fixed too
on 32bit, size_t is 32bit, but .st_size is off_t hence 64bit. Now you can this larger type to the smaller one, before comparing. This should be done the other way, i.e. the result of offsetof() should be cast to off_t before comparing.
(not an issue introduced by your PR, but if you touch this, please fix)
|
looks good, except for the type thing, see above. (which isn#t the fault of this PR, but should be fixed if the line is touched already) |
poettering
added
sd-bus
reviewed/needs-rework 🔨
> on 32bit, size_t is 32bit, but .st_size is off_t hence 64bit
keszybz
removed
the
reviewed/needs-rework 🔨
|
Updated. The only change is last patch to move the cast. |
poettering
added
the
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.