resolved: validate IP address in certificate for DNS-over-TLS (GnuTLS) #13870
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Today I read a blog post from CloudFlare in which they made made some statements about the current support of DNS-over-TLS for different systems. including systemd-resolved. This made me aware of a mistake I made in my pull request #12815. As there was some code lost after I did some cleanups and rebases before submitting the pull request.
Currently every certificate which is signed by a CA is accepted in strict mode when GnuTLS is used. This pull requests fix this by validating the IP address, as was intended with the previous pull request, as stated in the documentation and done when using OpenSSL.
note: I increased the required version of GnuTLS, because GNUTLS_DT_IP_ADDRESS was added in version 3.6.0