Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upsystemd-homed #14096
systemd-homed #14096
Conversation
- libutil-linux (libfdisk) - libpwquality - p11-kit See: systemd/systemd#14096
This comment has been minimized.
This comment has been minimized.
|
CI summary:
|
This comment has been minimized.
This comment has been minimized.
|
@mrc0mmand Thank so much for tracking these down! Much appreciated! |
This comment has been minimized.
This comment has been minimized.
|
Also, looks like the systemd-homed and systemd-logind services timeout throughout the integration testsuite:
Taken from this journal file, all logs can be found here. |
This comment has been minimized.
This comment has been minimized.
|
Also, another bunch of warnings from llvm/clang:
|
825d12c
to
98a61a1
This will help with several things, especially: - drop the plethora of CentOS 7 vs upstream systemd workarounds, like the custom Copr repo with various *mangled* dependencies - support systemd-homed (see: systemd/systemd#14096) - run more tests which depend on newer kernel's features
This will help with several things, especially: - drop the plethora of CentOS 7 vs upstream systemd workarounds, like the custom Copr repo with various *mangled* dependencies - support systemd-homed (see: systemd/systemd#14096) - run more tests which depend on newer kernel's features
This will help with several things, especially: - drop the plethora of CentOS 7 vs upstream systemd workarounds, like the custom Copr repo with various *mangled* dependencies - support systemd-homed (see: systemd/systemd#14096) - run more tests which depend on newer kernel's features
This comment has been minimized.
This comment has been minimized.
lgtm-com
bot
commented
Nov 21, 2019
|
This pull request introduces 7 alerts when merging 42a2e08 into 9389a3c - view on LGTM.com new alerts:
|
This comment has been minimized.
This comment has been minimized.
lgtm-com
bot
commented
Nov 21, 2019
|
This pull request introduces 3 alerts when merging eaeb0f9 into 9389a3c - view on LGTM.com new alerts:
|
This comment has been minimized.
This comment has been minimized.
|
@evverx as the local fuzzer master, do you have any idea what's going on in the Azure Pipelines? The current issue is that Ubuntu Xenial (16.x) has a pretty ancient
I'm not sure what causes that (maybe the clang version, which is Also, would it be possible to bump the whole fuzzit-related infrastructure to Ubuntu Bionic (18.x)? From a quick peek at the Azure documentation the |
This comment has been minimized.
This comment has been minimized.
|
@mrc0mmand as far as I can remember, on Azure Pipelines in addition to usual local builds the fuzzers are built with In the meantime, could you temporarily turn on TEST-*-HOMED under ASan+UBsan on CentOS CI so that the basic stuff could be covered before the PR got merged. Right now ASan is complaining about a memory leak somewhere in ^[[1m^[[31m==77==ERROR: LeakSanitizer: detected memory leaks^M
^[[1m^[[0m^M
^[[1m^[[34mDirect leak of 240 byte(s) in 1 object(s) allocated from:^M
^[[1m^[[0m #0 0x7f052f696c58 in __interceptor_malloc (/usr/lib64/libasan.so.5+0x10dc58)^M
#1 0x7f052e41653f in malloc_multiply ../src/basic/alloc-util.h:96^M
#2 0x7f052e41c5d7 in json_variant_new_object ../src/shared/json.c:652^M
#3 0x7f052e43105c in json_parse_internal ../src/shared/json.c:2901^M
#4 0x7f052e4340dc in json_parse ../src/shared/json.c:3130^M
#5 0x7f052e504373 in varlink_parse_message ../src/shared/varlink.c:580^M
#6 0x7f052e507529 in varlink_process ../src/shared/varlink.c:930^M
#7 0x7f052e5111e0 in defer_callback ../src/shared/varlink.c:1834^M
#8 0x7f052e893cfd in source_dispatch ../src/libsystemd/sd-event/sd-event.c:2860^M
#9 0x7f052e899fe2 in sd_event_dispatch ../src/libsystemd/sd-event/sd-event.c:3243^M
#10 0x7f052e89b05b in sd_event_run ../src/libsystemd/sd-event/sd-event.c:3301^M
#11 0x7f052e4f441e in userdb_process ../src/shared/userdb.c:555^M
#12 0x7f052e4f739f in groupdb_by_gid ../src/shared/userdb.c:861^M
#13 0x7f052e4cfccc in user_record_show ../src/shared/user-record-show.c:144^M
#14 0x40e21b in dump_home_record ../src/home/homectl.c:489^M
#15 0x40f438 in inspect_home ../src/home/homectl.c:613^M
#16 0x7f052e51b406 in dispatch_verb ../src/shared/verbs.c:112^M
#17 0x431961 in run ../src/home/homectl.c:3604^M
#18 0x431995 in main ../src/home/homectl.c:3607^M
#19 0x7f052cbadf42 in __libc_start_main (/usr/lib64/libc.so.6+0x23f42)^M
^M
^[[1m^[[34mIndirect leak of 1008 byte(s) in 5 object(s) allocated from:^M
^[[1m^[[0m #0 0x7f052f696c58 in __interceptor_malloc (/usr/lib64/libasan.so.5+0x10dc58)^M
#1 0x7f052e41653f in malloc_multiply ../src/basic/alloc-util.h:96^M
#2 0x7f052e41c5d7 in json_variant_new_object ../src/shared/json.c:652^M
#3 0x7f052e43105c in json_parse_internal ../src/shared/json.c:2901^M
#4 0x7f052e4340dc in json_parse ../src/shared/json.c:3130^M
#5 0x7f052e504373 in varlink_parse_message ../src/shared/varlink.c:580^M
#6 0x7f052e507529 in varlink_process ../src/shared/varlink.c:930^M
#7 0x7f052e5111e0 in defer_callback ../src/shared/varlink.c:1834^M
#8 0x7f052e893cfd in source_dispatch ../src/libsystemd/sd-event/sd-event.c:2860^M
#9 0x7f052e899fe2 in sd_event_dispatch ../src/libsystemd/sd-event/sd-event.c:3243^M
#10 0x7f052e89b05b in sd_event_run ../src/libsystemd/sd-event/sd-event.c:3301^M
#11 0x7f052e4f441e in userdb_process ../src/shared/userdb.c:555^M
#12 0x7f052e4f739f in groupdb_by_gid ../src/shared/userdb.c:861^M
#13 0x7f052e4cfccc in user_record_show ../src/shared/user-record-show.c:144^M
#14 0x40e21b in dump_home_record ../src/home/homectl.c:489^M
#15 0x40f438 in inspect_home ../src/home/homectl.c:613^M
#16 0x7f052e51b406 in dispatch_verb ../src/shared/verbs.c:112^M
#17 0x431961 in run ../src/home/homectl.c:3604^M
#18 0x431995 in main ../src/home/homectl.c:3607^M
#19 0x7f052cbadf42 in __libc_start_main (/usr/lib64/libc.so.6+0x23f42)^M
^Mand systemd-homed[60]: ../src/home/homed-manager.c:475:30: runtime error: left shift of 8388615 by 8 places cannot be represented in type 'int'
systemd-homed[60]: #0 0x446149 in search_quota ../src/home/homed-manager.c:475
systemd-homed[60]: #1 0x44763a in manager_acquire_uid ../src/home/homed-manager.c:582
systemd-homed[60]: #2 0x4493e3 in manager_augment_record_with_uid ../src/home/homed-manager.c:712
systemd-homed[60]: #3 0x43c24a in validate_and_allocate_home ../src/home/homed-manager-bus.c:377
systemd-homed[60]: #4 0x43cb6e in method_create_home ../src/home/homed-manager-bus.c:469
systemd-homed[60]: #5 0x7fc7b288d0e8 in method_callbacks_run ../src/libsystemd/sd-bus/bus-objects.c:409
systemd-homed[60]: #6 0x7fc7b2896e0a in object_find_and_run ../src/libsystemd/sd-bus/bus-objects.c:1332
systemd-homed[60]: #7 0x7fc7b28984b7 in bus_process_object ../src/libsystemd/sd-bus/bus-objects.c:1452
systemd-homed[60]: #8 0x7fc7b28f5222 in process_message ../src/libsystemd/sd-bus/sd-bus.c:2763
systemd-homed[60]: #9 0x7fc7b28f57ab in process_running ../src/libsystemd/sd-bus/sd-bus.c:2805
systemd-homed[60]: #10 0x7fc7b28f860a in bus_process_internal ../src/libsystemd/sd-bus/sd-bus.c:3025
systemd-homed[60]: #11 0x7fc7b28f87cf in sd_bus_process ../src/libsystemd/sd-bus/sd-bus.c:3052
systemd-homed[60]: #12 0x7fc7b28fc1ad in io_callback ../src/libsystemd/sd-bus/sd-bus.c:3404
systemd-homed[60]: #13 0x7fc7b29eb552 in source_dispatch ../src/libsystemd/sd-event/sd-event.c:2830
systemd-homed[60]: #14 0x7fc7b29f1fe2 in sd_event_dispatch ../src/libsystemd/sd-event/sd-event.c:3243
systemd-homed[60]: #15 0x7fc7b29f305b in sd_event_run ../src/libsystemd/sd-event/sd-event.c:3301
systemd-homed[60]: #16 0x7fc7b29f341d in sd_event_loop ../src/libsystemd/sd-event/sd-event.c:3323
systemd-homed[60]: #17 0x45e533 in run ../src/home/homed.c:39
systemd-homed[60]: #18 0x45e711 in main ../src/home/homed.c:46
systemd-homed[60]: #19 0x7fc7b0d05f42 in __libc_start_main (/usr/lib64/libc.so.6+0x23f42)
systemd-homed[60]: #20 0x4087cd in _start (/usr/lib/systemd/systemd-homed+0x4087cd)
systemd-homed[60]: SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../src/home/homed-manager.c:475:30 in
systemd-homed[60]: ../src/home/homed-home.c:2056:30: runtime error: left shift of 8388615 by 8 places cannot be represented in type 'int'
systemd-homed[60]: #0 0x42eb18 in home_get_disk_status_directory ../src/home/homed-home.c:2056
systemd-homed[60]: #1 0x42fba9 in home_augment_status ../src/home/homed-home.c:2149
systemd-homed[60]: #2 0x40be4f in bus_home_get_record_json ../src/home/homed-home-bus.c:104
systemd-homed[60]: #3 0x43a7a3 in method_get_user_record_by_name ../src/home/homed-manager-bus.c:222
systemd-homed[60]: #4 0x7fc7b288d0e8 in method_callbacks_run ../src/libsystemd/sd-bus/bus-objects.c:409
systemd-homed[60]: #5 0x7fc7b2896e0a in object_find_and_run ../src/libsystemd/sd-bus/bus-objects.c:1332
systemd-homed[60]: #6 0x7fc7b28984b7 in bus_process_object ../src/libsystemd/sd-bus/bus-objects.c:1452
systemd-homed[60]: #7 0x7fc7b28f5222 in process_message ../src/libsystemd/sd-bus/sd-bus.c:2763
systemd-homed[60]: #8 0x7fc7b28f57ab in process_running ../src/libsystemd/sd-bus/sd-bus.c:2805
systemd-homed[60]: #9 0x7fc7b28f860a in bus_process_internal ../src/libsystemd/sd-bus/sd-bus.c:3025
systemd-homed[60]: #10 0x7fc7b28f87cf in sd_bus_process ../src/libsystemd/sd-bus/sd-bus.c:3052
systemd-homed[60]: #11 0x7fc7b28fc1ad in io_callback ../src/libsystemd/sd-bus/sd-bus.c:3404
systemd-homed[60]: #12 0x7fc7b29eb552 in source_dispatch ../src/libsystemd/sd-event/sd-event.c:2830
systemd-homed[60]: #13 0x7fc7b29f1fe2 in sd_event_dispatch ../src/libsystemd/sd-event/sd-event.c:3243
systemd-homed[60]: #14 0x7fc7b29f305b in sd_event_run ../src/libsystemd/sd-event/sd-event.c:3301
systemd-homed[60]: #15 0x7fc7b29f341d in sd_event_loop ../src/libsystemd/sd-event/sd-event.c:3323
systemd-homed[60]: #16 0x45e533 in run ../src/home/homed.c:39
systemd-homed[60]: #17 0x45e711 in main ../src/home/homed.c:46
systemd-homed[60]: #18 0x7fc7b0d05f42 in __libc_start_main (/usr/lib64/libc.so.6+0x23f42)
systemd-homed[60]: #19 0x4087cd in _start (/usr/lib/systemd/systemd-homed+0x4087cd)
systemd-homed[60]: SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../src/home/homed-home.c:2056:30 in |
This comment has been minimized.
This comment has been minimized.
lgtm-com
bot
commented
Nov 22, 2019
|
This pull request introduces 3 alerts when merging 53e474a into bdf2357 - view on LGTM.com new alerts:
|
This comment has been minimized.
This comment has been minimized.
lgtm-com
bot
commented
Jan 20, 2020
|
This pull request introduces 1 alert when merging f07855a into 5608deb - view on LGTM.com new alerts:
|
d0a1997
to
65f8733
This comment has been minimized.
This comment has been minimized.
lgtm-com
bot
commented
Jan 23, 2020
|
This pull request introduces 1 alert when merging 65f8733 into e1d32d6 - view on LGTM.com new alerts:
|
This comment has been minimized.
This comment has been minimized.
lgtm-com
bot
commented
Jan 26, 2020
|
This pull request introduces 1 alert when merging 6893197 into 0de6103 - view on LGTM.com new alerts:
|
This comment has been minimized.
This comment has been minimized.
lgtm-com
bot
commented
Jan 28, 2020
|
This pull request introduces 1 alert when merging bf96976 into 7d20404 - view on LGTM.com new alerts:
|
…el and efsck to build This is preparation for subsequent additions which link against these libraries.
Fixes more or less: https://bugs.freedesktop.org/show_bug.cgi?id=67474
In a way fixes: https://bugs.freedesktop.org/show_bug.cgi?id=67474
This comment has been minimized.
This comment has been minimized.
lgtm-com
bot
commented
Jan 28, 2020
|
This pull request introduces 1 alert when merging c809ed7 into 1ffadea - view on LGTM.com new alerts:
|
|
OK, let's merge. I'm sure that there's still many tweaks to be done, but we can do that more effectively in-tree. |
| @@ -2034,6 +2062,35 @@ if conf.get('ENABLE_USERDB') == 1 | |||
| install_dir : rootbindir) | |||
| endif | |||
|
|
|||
| if conf.get('ENABLE_HOMED') == 1 | |||
| executable('systemd-homework', | |||
This comment has been minimized.
This comment has been minimized.
| bool suitable_user_name(const char *name) { | ||
|
|
||
| /* Checks whether the specified name is suitable for management via homed. Note that our client side | ||
| * usually validate susing a simple valid_user_group_name(), while server side we are a bit more |
This comment has been minimized.
This comment has been minimized.
| @@ -1316,6 +1330,19 @@ else | |||
| endif | |||
| conf.set10('ENABLE_IMPORTD', have) | |||
|
|
|||
| want_homed = get_option('homed') | |||
| if want_homed != 'false' | |||
This comment has been minimized.
This comment has been minimized.
keszybz
Jan 30, 2020
Member
This doesn't work because the option is a boolean. I'll submit a patch for this after merging.
poettering commentedNov 20, 2019
Yupp, as presented at AllSystemsGo! 2019, here it is! Should be pretty complete, with LUKS and fscrypt backends, with PKCS#11 yubikey unlocking, key suspending during system sleep, and lots and lots of other fancy features.