Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network: fix routing policy rule issue #16986

Merged
merged 8 commits into from
Sep 10, 2020
Merged

network: fix routing policy rule issue #16986

merged 8 commits into from
Sep 10, 2020

Conversation

yuwata
Copy link
Member

@yuwata yuwata commented Sep 8, 2020

Fixes #16784.

@yuwata yuwata added the network label Sep 8, 2020
@yuwata yuwata mentioned this pull request Sep 8, 2020
Closed
@yuwata yuwata force-pushed the network-fix-routing-policy-rule-issue-16784 branch from 0fa5c43 to 9c2272c Compare September 8, 2020 22:17
@yuwata
network: update log message for rtnl messages
b6c7c4a
@yuwata
network: also logs priority of routing policy rules
755dbda
@yuwata
network: add debug log for removing routing policy rules
d85b0d6
@yuwata
network: do not assign return value if the parse_fwmark_fwmask() fails
c2d6fcb 
This also removes redundant logs, and makes input string not copied if
it does not contain '/'.
@yuwata
network: fix the default mask for FirewallMark=
bd1000b 
And always send FRA_FWMASK if FirewallMark= is set.

C.f. torvalds/linux@b8964ed

Partially fixes systemd#16784.
@yuwata
network: also process RTM_NEWRULE or RTM_DELRULE message which does n…
2102d33 
…ot contain src and dst addresses

Fixes systemd#16784.
@yuwata
network: replace FRA_IFNAME -> FRA_IIFNAME
17d2b2e 
No functional change, as FRA_IFNAME is an alias of FRA_IIFNAME.
@yuwata
test-network: update tests for issue systemd#16784
87adeab
@yuwata yuwata force-pushed the network-fix-routing-policy-rule-issue-16784 branch from 9c2272c to 87adeab Compare September 10, 2020 10:00
@yuwata
Copy link
Member Author

yuwata commented Sep 10, 2020

@poettering Thank you for the review. I hope that the above two points are addressed now. Setting the green label.

@yuwata yuwata added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed good-to-merge/with-minor-suggestions labels Sep 10, 2020
@poettering poettering merged commit 3a17308 into systemd:master Sep 10, 2020
@yuwata yuwata deleted the network-fix-routing-policy-rule-issue-16784 branch September 10, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poettering poettering poettering left review comments

Assignees
No one assigned
Labels
good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed network
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RoutingPolicyRule not applied on reconfigure
2 participants
@yuwata @poettering