unit: don't emit PropertiesChanged signal if adding a dependency to a unit is a no-op #17234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmetrich
force-pushed
the
unit_adddep_noop
branch
from
09eb35a
to
2cd4db2
Compare
|
This patch is awesome. Dbus exhaustion was killing my infrastructure, stalling SSH on dbus timeouts (25 seconds!!). Thanks for addressing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time /proc/self/mountinfo is parsed, a PropertiesChanged signal is sent for remote mounts (NFS, CIFS, etc.).
This is due to unit_add_dependency() being called for each remote mount entry to set up the Before dependency on remote-fs.target.
For existing mounts, this has already be done in the past, so it's not necessary to do this over and over.
This avoids sending bursts of PropertiesChanged messages on systems having many remote mounts (e.g. Openshift deployments).
This is somehow a continuation of PR #15233 (#15233).