journalctl: skipping the repeating entries at the conjunction of .jou… #18013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this hides a bug. So I think I figured it out: in journal_file_append_entry_internal() we'll pick a seqnum, and then try to insert the journal entry. And if that works, great. But if the journal file would grow too large we fail — but do not revert the seqnum to the old value. thus, after we started a new file, and try to write again the same entry, we'll do so with an even higher seqnum. So I guess we need to revert to the previous seqnum on failure. |
|
Nice catch! |
|
#18670 got merged, that fixes this. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rnal files
#18005