chrattr-util: return EOPNOTSUPP from chrattr_full if no other failure was observed #21906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was observed When chattr_full tries to apply flags one-by-one, and one fails, record which errno was returned. But record EOPNOTSUPP(&friends) only if no other error is observed, and return it only in that case (otherwise keep returning ENOANO), so that callers can respond appropriately to EOPNOTSUPP vs more relevant errors. For example, this lets tmpfiles.d log at debug level when a filesystem flag cannot be applied because the filesystem does not support it, but at warning level if something else went wrong when applying it. Restores logging behaviour of tmpfiles.d to pre-250. Follow-up for: systemd@c1631ee Fixes: systemd#21901
|
LGTM. |
|
Needs to be backported to v250-stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When chattr_full tries to apply flags one-by-one, and one fails,
record which errno was returned. But record EOPNOTSUPP(&friends)
only if no other error is observed, and return it only in that case
(otherwise keep returning ENOANO), so that callers can respond
appropriately to EOPNOTSUPP vs more relevant errors.
For example, this lets tmpfiles.d log at debug level when a filesystem
flag cannot be applied because the filesystem does not support it,
but at warning level if something else went wrong when applying it.
Restores logging behaviour of tmpfiles.d to pre-250.
Follow-up for: c1631ee
Fixes: #21901